Skip to content

Commit bf6629a

Browse files
committed
D3D12: Fix shader model check, initialization error handling
1 parent 037956d commit bf6629a

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

drivers/d3d12/rendering_device_driver_d3d12.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5839,7 +5839,7 @@ Error RenderingDeviceDriverD3D12::_check_capabilities() {
58395839

58405840
#define D3D_SHADER_MODEL_TO_STRING(m_sm) vformat("%d.%d", (m_sm >> 4), (m_sm & 0xf))
58415841

5842-
ERR_FAIL_COND_V_MSG(!shader_capabilities.shader_model, ERR_UNAVAILABLE,
5842+
ERR_FAIL_COND_V_MSG(shader_capabilities.shader_model < SMS_TO_CHECK[ARRAY_SIZE(SMS_TO_CHECK) - 1], ERR_UNAVAILABLE,
58435843
vformat("No support for any of the suitable shader models (%s-%s) has been found.", D3D_SHADER_MODEL_TO_STRING(SMS_TO_CHECK[ARRAY_SIZE(SMS_TO_CHECK) - 1]), D3D_SHADER_MODEL_TO_STRING(SMS_TO_CHECK[0])));
58445844

58455845
print_verbose("- Shader:");
@@ -6058,6 +6058,8 @@ Error RenderingDeviceDriverD3D12::_initialize_command_signatures() {
60586058
}
60596059

60606060
Error RenderingDeviceDriverD3D12::initialize(uint32_t p_device_index, uint32_t p_frame_count) {
6061+
glsl_type_singleton_init_or_ref();
6062+
60616063
context_device = context_driver->device_get(p_device_index);
60626064
adapter = context_driver->create_adapter(p_device_index);
60636065
ERR_FAIL_NULL_V(adapter, ERR_CANT_CREATE);
@@ -6087,7 +6089,5 @@ Error RenderingDeviceDriverD3D12::initialize(uint32_t p_device_index, uint32_t p
60876089
err = _initialize_command_signatures();
60886090
ERR_FAIL_COND_V(err != OK, ERR_CANT_CREATE);
60896091

6090-
glsl_type_singleton_init_or_ref();
6091-
60926092
return OK;
60936093
}

servers/rendering/rendering_device.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6688,7 +6688,6 @@ Error RenderingDevice::initialize(RenderingContextDriver *p_context, DisplayServ
66886688
}
66896689

66906690
frame = 0;
6691-
frames.resize(frame_count);
66926691
max_timestamp_query_elements = GLOBAL_GET("debug/settings/profiler/max_timestamp_query_elements");
66936692

66946693
device = context->device_get(device_index);
@@ -6757,6 +6756,8 @@ Error RenderingDevice::initialize(RenderingContextDriver *p_context, DisplayServ
67576756
// Use the processor count as the max amount of transfer workers that can be created.
67586757
transfer_worker_pool_max_size = OS::get_singleton()->get_processor_count();
67596758

6759+
frames.resize(frame_count);
6760+
67606761
// Create data for all the frames.
67616762
for (uint32_t i = 0; i < frames.size(); i++) {
67626763
frames[i].index = 0;

servers/rendering/rendering_device_graph.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1575,7 +1575,9 @@ void RenderingDeviceGraph::initialize(RDD *p_driver, RenderingContextDriver::Dev
15751575
}
15761576

15771577
void RenderingDeviceGraph::finalize() {
1578-
_wait_for_secondary_command_buffer_tasks();
1578+
if (!frames.is_empty()) {
1579+
_wait_for_secondary_command_buffer_tasks();
1580+
}
15791581

15801582
for (Frame &f : frames) {
15811583
for (SecondaryCommandBuffer &secondary : f.secondary_command_buffers) {

0 commit comments

Comments
 (0)