Skip to content

Commit c263b20

Browse files
committed
Merge pull request #109735 from mihe/infinite-doc-regen
Fix/remove error about "Can't update documentation" when saving script
2 parents d743dcc + c43425a commit c263b20

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

editor/file_system/editor_file_system.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1768,13 +1768,13 @@ void EditorFileSystem::_notification(int p_what) {
17681768
// Set first_scan to false before the signals so the function doing_first_scan can return false
17691769
// in editor_node to start the export if needed.
17701770
first_scan = false;
1771+
scanning_changes = false;
1772+
done_importing = true;
17711773
ResourceImporter::load_on_startup = nullptr;
17721774
if (changed) {
17731775
emit_signal(SNAME("filesystem_changed"));
17741776
}
17751777
emit_signal(SNAME("sources_changed"), sources_changed.size() > 0);
1776-
scanning_changes = false; // Changed to false here to prevent recursive triggering of scan thread.
1777-
done_importing = true;
17781778
}
17791779
} else if (!scanning && thread.is_started()) {
17801780
set_process(false);

editor/script/script_editor_plugin.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3783,8 +3783,6 @@ bool ScriptEditor::_help_tab_goto(const String &p_name, const String &p_desc) {
37833783
}
37843784

37853785
void ScriptEditor::update_doc(const String &p_name) {
3786-
ERR_FAIL_COND_MSG(!EditorHelp::has_doc(p_name), vformat("Can't update documentation for \"%s\".", p_name));
3787-
37883786
for (int i = 0; i < tab_container->get_tab_count(); i++) {
37893787
EditorHelp *eh = Object::cast_to<EditorHelp>(tab_container->get_tab_control(i));
37903788
if (eh && eh->get_class() == p_name) {

0 commit comments

Comments
 (0)