Skip to content

Commit d85dbee

Browse files
committed
Fix apk install after gradle build for the Android editor
1 parent 7ed0b61 commit d85dbee

File tree

3 files changed

+11
-2
lines changed

3 files changed

+11
-2
lines changed

platform/android/export/android_editor_gradle_runner.cpp

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,17 @@
3232
#include "android_editor_gradle_runner.h"
3333

3434
#include "editor/editor_interface.h"
35+
#include "editor/settings/editor_settings.h"
3536
#include "scene/gui/dialogs.h"
3637
#include "scene/gui/rich_text_label.h"
3738

3839
#include "../java_godot_wrapper.h"
3940
#include "../os_android.h"
4041

41-
void AndroidEditorGradleRunner::run_gradle(const String &p_project_path, const String &p_build_path, const List<String> &p_gradle_build_args, const List<String> &p_gradle_copy_args) {
42+
void AndroidEditorGradleRunner::run_gradle(const String &p_project_path, const String &p_build_path, const String &p_output_path, const List<String> &p_gradle_build_args, const List<String> &p_gradle_copy_args) {
4243
project_path = p_project_path;
4344
build_path = p_build_path;
45+
output_path = p_output_path;
4446
gradle_build_args = p_gradle_build_args;
4547
gradle_copy_args = p_gradle_copy_args;
4648

@@ -151,6 +153,11 @@ void AndroidEditorGradleRunner::_android_gradle_build_clean_project(bool p_was_s
151153

152154
if (p_was_successful) {
153155
output_dialog->hide();
156+
157+
bool prompt_apk_install = EDITOR_GET("export/android/install_exported_apk");
158+
if (prompt_apk_install) {
159+
OS_Android::get_singleton()->shell_open(output_path);
160+
}
154161
} else {
155162
output_dialog->get_ok_button()->set_disabled(false);
156163
}

platform/android/export/android_editor_gradle_runner.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ class AndroidEditorGradleRunner : public Object {
5252

5353
String project_path;
5454
String build_path;
55+
String output_path;
5556
List<String> gradle_build_args;
5657
List<String> gradle_copy_args;
5758
int64_t job_id;
@@ -70,7 +71,7 @@ class AndroidEditorGradleRunner : public Object {
7071
void _android_gradle_build_cancel();
7172

7273
public:
73-
void run_gradle(const String &p_project_path, const String &p_build_path, const List<String> &p_gradle_build_args, const List<String> &p_gradle_copy_args);
74+
void run_gradle(const String &p_project_path, const String &p_build_path, const String &p_output_path, const List<String> &p_gradle_build_args, const List<String> &p_gradle_copy_args);
7475
};
7576

7677
#endif // ANDROID_ENABLED

platform/android/export/export_plugin.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3954,6 +3954,7 @@ Error EditorExportPlatformAndroid::export_project_helper(const Ref<EditorExportP
39543954
android_editor_gradle_runner->run_gradle(
39553955
project_path,
39563956
build_path.substr(project_path.length()),
3957+
export_path.path_join(export_filename),
39573958
cmdline,
39583959
copy_args);
39593960
#else

0 commit comments

Comments
 (0)