Skip to content

Commit e605ad9

Browse files
committed
Fix inefficient upload in Mobile Shadows
Clustered performs the following shadow rendering steps 1. Process objects [0; 10) for cascade 0. 2. Process objects [10; 30) for cascade 1. 3. Process objects [30; 100) for cascade 2. 4. Upload objects [0; 100) to GPU. 5. Draw all cascades. Mobile was supposed to be doing the same, but instead was doing: 1. Process objects [0; 10) for cascade 0. 2. Upload objects [0; 10) to GPU. 3. Process objects [10; 30) for cascade 1. 4. Upload objects [0; 30) to GPU. 5. Process objects [30; 100) for cascade 2. 6. Upload objects [0; 100) to GPU. 7. Draw all cascades. That is, always reuploaded everything from scratch. Therefore it pointlessly (and with geometric growth) wasted BW.
1 parent 134da37 commit e605ad9

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

servers/rendering/renderer_rd/forward_mobile/render_forward_mobile.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1426,6 +1426,7 @@ void RenderForwardMobile::_render_shadow_begin() {
14261426
_update_render_base_uniform_set();
14271427

14281428
render_list[RENDER_LIST_SECONDARY].clear();
1429+
scene_state.instance_data[RENDER_LIST_SECONDARY].clear();
14291430
}
14301431

14311432
void RenderForwardMobile::_render_shadow_append(RID p_framebuffer, const PagedArray<RenderGeometryInstance *> &p_instances, const Projection &p_projection, const Transform3D &p_transform, float p_zfar, float p_bias, float p_normal_bias, bool p_use_dp, bool p_use_dp_flip, bool p_use_pancake, float p_lod_distance_multiplier, float p_screen_mesh_lod_threshold, const Rect2i &p_rect, bool p_flip_y, bool p_clear_region, bool p_begin, bool p_end, RenderingMethod::RenderInfo *p_render_info, const Transform3D &p_main_cam_transform) {

0 commit comments

Comments
 (0)