Add bracket pair colorization for GDScriptSyntaxHighlighter #112314
Conversation
|
Check if there's already a proposal and mention it next time. Either way, this does close godotengine/godot-proposals#4728 . Could you provide screenshots to see how this looks by default? |
|
You've used a merge commit for your branch, this probably means you aren't pushing correctly, please use |
|
Sorry, I'm not familiar with Git operations. I'm currently working on resolving this issue. |
|
For some details on how to use the workflows see here |
AdvanceControl
force-pushed
the
add_bracket_pair_colorization
branch
from
05a0259 to
714ea33
Compare
Yes.By default, it appears like this |
AdvanceControl
force-pushed
the
add_bracket_pair_colorization
branch
3 times, most recently
from
51926c1 to
cf8bca5
Compare
Mickeon
left a comment
Mickeon
left a comment
There was a problem hiding this comment.
I can't speak much on the quality of the code. There may be a few things that could be optimized. However, the feature itself has been positively requested for quite a while, and it does improve readability for many.
One thing I have to wonder is how the feature itself is exposed. For one, I figured the colorization option would've been a slider controlling the saturation change relative to the base parenthesis color, but this may make more sense and it's more customizable.
We also potentially need to choose more appropriate defaults for these colors. As they are currently, they're clearly inspired by Visual Studio Code, but they may not make as much sense here and even less so in GDScript.
AdvanceControl
force-pushed
the
add_bracket_pair_colorization
branch
from
cf8bca5 to
9edd912
Compare
AdvanceControl
force-pushed
the
add_bracket_pair_colorization
branch
from
af860e8 to
40de66d
Compare
I made a slight change to the default color. Are you suggesting something with higher contrast, or perhaps a palette that aligns more closely with Godot's existing brand/UI colors, or other? |
4 participants
EDIT:Fixes godotengine/godot-proposals#4728
This PR Assigns cycling colors to nested pairs of
(),[], and{}to improve code readability.