Commit fbfdd73
committed
fix: address review comments for ExpireCookie
- Add CookieSameSiteDisabled handling in ExpireCookie to not set
SameSite attribute when explicitly disabled
- Fix documentation signature to show fiber.Res receiver instead of
fiber.Ctx
- Add test case for CookieSameSiteDisabled to verify SameSite is not
present in Set-Cookie header1 parent efcc881 commit fbfdd73
3 files changed
+19
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4550 | 4550 | | |
4551 | 4551 | | |
4552 | 4552 | | |
4553 | | - | |
4554 | | - | |
4555 | | - | |
| 4553 | + | |
| 4554 | + | |
| 4555 | + | |
| 4556 | + | |
4556 | 4557 | | |
4557 | 4558 | | |
4558 | 4559 | | |
| |||
4621 | 4622 | | |
4622 | 4623 | | |
4623 | 4624 | | |
| 4625 | + | |
| 4626 | + | |
| 4627 | + | |
| 4628 | + | |
| 4629 | + | |
| 4630 | + | |
| 4631 | + | |
| 4632 | + | |
| 4633 | + | |
4624 | 4634 | | |
4625 | 4635 | | |
4626 | 4636 | | |
| |||
4636 | 4646 | | |
4637 | 4647 | | |
4638 | 4648 | | |
| 4649 | + | |
| 4650 | + | |
| 4651 | + | |
4639 | 4652 | | |
4640 | 4653 | | |
4641 | 4654 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1777 | 1777 | | |
1778 | 1778 | | |
1779 | 1779 | | |
1780 | | - | |
| 1780 | + | |
1781 | 1781 | | |
1782 | 1782 | | |
1783 | 1783 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
250 | 250 | | |
251 | 251 | | |
252 | 252 | | |
| 253 | + | |
| 254 | + | |
253 | 255 | | |
254 | 256 | | |
255 | 257 | | |
| |||
0 commit comments