🐛 [Bug]: Redis secure connection not working properly

[mirusky]

Bug Description

When trying to connect to a rediss (redis secure) it fails.

I'm supposing that is a problem with the storage/redis, since go-redis is handling it here and returning options with tls, but storage/redis is not handling it as we can see it here, it's not setting the TLS config.

How to Reproduce

Steps to reproduce the behavior:

1. Create a new redis storage
2. Pass the URL as rediss (redis secure) protocol
3. Try to use the store

Expected Behavior

Connection established with TLS.

Storage package Version

v2.0.3

Code Snippet (optional)

package main

import "fmt"

func main() {

	store = redis.New(redis.Config{
		URL: "rediss://<user>:<pass>@127.0.0.1:6379/<db>",
	})

	fmt.Println(store.Get(key))

}

Checklist:

• I agree to follow Fiber's Code of Conduct.
• I have checked for existing issues that describe my problem prior to opening this one.
• I understand that improperly formatted bug reports may be closed without explanation.

[gaby]

@mirusky Thanks for the report, will fix it today.

[gaby]

@mirusky This issue exposes a problem with go-redis that hasn't been fixed yet. If you use rediss there's no way to specify anything related to TLSConfig.

Related PR: redis/go-redis#2076
Issue: redis/go-redis#2024

The way of using Redis Secure with Fiber Storage is this way:

tlsCfg := &tls.Config{
	MinVersion:               tls.VersionTLS12,
	InsecureSkipVerify:       true,
	Certificates:             []tls.Certificate{cer},
}
store = redis.New(redis.Config{
    URL:     	"redis://<user>:<pass>@127.0.0.1:6379/<db>",
	TLSConfig: 	tlsCfg,
    Reset:    	false,
})

I can make the driver use the TLSConfig returned by Options if it's not provided through the config, would that work for you?

[gaby]

This is the solution I have right now:

// If cfg.TLSConfig is not provided, and options returns one, use it.
if cfg.TLSConfig == nil && options.TLSConfig != nil {
	cfg.TLSConfig = options.TLSConfig
}

I can't write a unit-test for it since there's no way to change the TLSConfig settings when using rediss://<user>:<pass>@127.0.0.1:6379/<db>

[gaby]

@mirusky Redis requires MTLS, so this won't work unless the server has MTLS disabled or the Redis team fixes redis/go-redis#2024

[gaby]

I was able to write a test for this :-)