Merge branch 'master' into chore-service-fqdn-5549

* master: (175 commits)
  chore(deps): bump renovatebot/github-action (kubernetes-sigs#5890)
  chore(cloudflare): migrate DeleteCustomHostname() to new lib (kubernetes-sigs#5880)
  docs(advanced): configuration precedence (kubernetes-sigs#5871)
  test: update goversion label to 1.25 in metrics test (kubernetes-sigs#5886)
  ci(linter): add go-critic (kubernetes-sigs#5875)
  docs(providers): add info about Myra protection option and docker image (kubernetes-sigs#5879)
  refactor(pihole): reduce cyclomatic complexity of TestProviderV6 (kubernetes-sigs#5876)
  test(source/service): add serviceTypeFilter edge case (kubernetes-sigs#5872)
  chore(ci): speed-up & coveralls (kubernetes-sigs#5870)
  feat(provider/cloudflare): add support for tags (kubernetes-sigs#5862)
  chore(deps): bump renovatebot/github-action (kubernetes-sigs#5874)
  feat: add new flags to allow migration of OwnerID (kubernetes-sigs#4823)
  docs(volcengine): add volcengine provider to readme (kubernetes-sigs#5866)
  chore(deps): bump renovatebot/github-action (kubernetes-sigs#5856)
  docs improve txt registry documentation formatting and examples for apex record (kubernetes-sigs#5863)
  chore: upgrade ExternalDNS to go v1.25 and golangci-lint v2.5 (kubernetes-sigs#5869)
  refactor(pihole): reduce cyclomatic complexity of TestProvider (kubernetes-sigs#5865)
  refactor(service): reduce cyclomatic complexity of extractHeadlessEndpoints (kubernetes-sigs#5822)
  test(cloudflare): clear environment variables before setting test values (kubernetes-sigs#5851)
  fix(endpoint/source) Allow '.' in TXT Records (kubernetes-sigs#5844)
  ...

Author: ivankatliarchuk

.editorconfig

@@ -20,3 +20,7 @@ insert_final_newline = true
 [{Makefile,go.mod,go.sum,*.go}]
 indent_style = tab
 indent_size = 4
+
+[*.py]
+indent_style = space
+indent_size = 4

.github/ISSUE_TEMPLATE/---bug-report.md

@@ -7,8 +7,10 @@ assignees: ''
 
 ---
 
-<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!
+<!--
+Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!
 
+Make sure to validate the behavior against latest release https://github.com/kubernetes-sigs/external-dns/releases as we don't support past versions.
 -->
 
 **What happened**:
@@ -17,6 +19,10 @@ assignees: ''
 
 **How to reproduce it (as minimally and precisely as possible)**:
 
+<!--
+Please provide as much detail as possible, including Kubernetes manifests with spec.status, ExternalDNS arguments, and logs. A bug that cannot be reproduced won't be fixed.
+-->
+
 **Anything else we need to know?**:
 
 **Environment**:

.github/workflows/ci.yaml

@@ -11,12 +11,12 @@ permissions:
 
 jobs:
 
-  build:
+  test:
     permissions:
       contents: read  #  to fetch code (actions/checkout)
       checks: write  #  to create a new check based on the results (shogo82148/actions-goveralls)
 
-    name: Build
+    name: Test
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
@@ -25,31 +25,41 @@ jobs:
     steps:
 
     - name: Check out code into the Go module directory
-      uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+      uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
 
     - name: Set up Go 1.x
-      uses: actions/setup-go@v5
+      uses: actions/setup-go@v6
       with:
         go-version-file: go.mod
         check-latest: true
       id: go
 
-    - name: Install CI
+    - name: Install Dependencies
       run: |
         go get -v -t -d ./...
 
-    - name: Install additional CI for nektos/act
-      run: |
-            apt update
-            apt install -y make gcc libc-dev git
-      if: github.actor == 'nektos/act' && matrix.os == 'ubuntu-latest'
-
     - name: Test
-      run: make test
+      env:
+        GOMAXPROCS: 4
+        GOMEMLIMIT: 8192MiB
+      run: make go-test
 
     - name: Send coverage
-      uses: shogo82148/actions-goveralls@v1
+      uses: coverallsapp/github-action@v2
       with:
-        path-to-profile: profile.cov
-      if: github.actor != 'nektos/act' && matrix.os == 'ubuntu-latest'
+        file: profile.cov
+        format: golang
+        flag-name: run-${{ join(matrix.*, '-') }}
+        parallel: true
       continue-on-error: true
+
+  finish:
+    needs: test
+    if: ${{ always() }}
+    runs-on: ubuntu-latest
+    steps:
+    - name: Coveralls Finished
+      uses: coverallsapp/github-action@v2
+      with:
+        parallel-finished: true
+        carryforward: "run-ubuntu-latest,run-macos-latest"

.github/workflows/codeql-analysis.yaml

@@ -26,9 +26,9 @@ jobs:
 
     steps:
     - name: Checkout repository
-      uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+      uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
     - name: Install go version
-      uses: actions/setup-go@v5
+      uses: actions/setup-go@v6
       with:
         go-version-file: go.mod
 

.github/workflows/dependency-update.yaml

@@ -14,10 +14,10 @@ jobs:
     if: github.repository == 'kubernetes-sigs/external-dns'
     steps:
       - name: checkout
-        uses: actions/checkout@v4.2.2
+        uses: actions/checkout@v5.0.0
       # https://github.com/renovatebot/github-action
       - name: self-hosted renovate
-        uses: renovatebot/github-action@v42.0.6
+        uses: renovatebot/github-action@v43.0.15
         with:
           # https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication
           token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/docs.yaml

@@ -18,11 +18,11 @@ jobs:
     name: Release Docs
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
         with:
           fetch-depth: 0
 
-      - uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
+      - uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6.0.0
         with:
           python-version: "3.12"
           cache: "pip"

.github/workflows/gh-workflow-approve.yaml

@@ -17,7 +17,7 @@ jobs:
       actions: write
     steps:
       - name: Update PR
-        uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
+        uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
         continue-on-error: true
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/json-yaml-validate.yml

@@ -14,10 +14,10 @@ jobs:
   json-yaml-validate:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
 
       - name: json-yaml-validate
-        uses: GrantBirki/json-yaml-validate@v3.2.1 # pin @v3.2.1 bug in 3.3.0: https://github.com/GrantBirki/json-yaml-validate/issues/86
+        uses: GrantBirki/json-yaml-validate@v3.3.1
         with:
           # ref: https://github.com/GrantBirki/json-yaml-validate?tab=readme-ov-file#inputs-
           comment: "true" # enable comment mode

.github/workflows/lint-test-chart.yaml

@@ -25,12 +25,12 @@ jobs:
         shell: bash
     steps:
       - name: Checkout
-        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
         with:
           fetch-depth: 0
 
       - name: Install Helm
-        uses: azure/setup-helm@b9e51907a09c216f16ebe8536097933489208112 # v4.3.0
+        uses: azure/setup-helm@1a275c3b69536ee54be43f2070a358922e12c8d4 # v4.3.1
         with:
           version: latest
 
@@ -178,7 +178,7 @@ jobs:
         run: ah lint --kind helm --path ./charts/external-dns || exit 1
 
       - name: Install Python
-        uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
+        uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6.0.0
         with:
           token: ${{ github.token }}
           python-version: "3.x"

.github/workflows/lint.yaml

@@ -18,7 +18,7 @@ jobs:
     steps:
 
     - name: Check out code into the Go module directory
-      uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+      uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
 
     - name: Lint markdown
       uses: nosborn/[email protected]
@@ -27,7 +27,7 @@ jobs:
         config_file: ".markdownlint.json"
 
     - name: Set up Go
-      uses: actions/setup-go@v5
+      uses: actions/setup-go@v6
       with:
         go-version-file: go.mod
 
@@ -48,15 +48,16 @@ jobs:
       with:
         verify: true
         args: --timeout=30m
-        version: v2.1
+        version: v2.5
 
-      # Run Spectral
+      # https://github.com/daveshanley/vacuum
     - name: Lint OpenAPI spec
-      uses: stoplightio/spectral-action@577bade2d6e0eeb50528c94182a5588bf961ae8f # v0.8.12
-      with:
-        file_glob: 'api/*.yaml'
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}  # Increases rate limit from 60 to 5000 requests
+      run: |
+        go tool vacuum lint -d --fail-severity warn --show-rules api/*.yaml
 
-    - uses: actions/setup-python@v5
+    - uses: actions/setup-python@v6
     # https://github.com/pre-commit/action
     - name: Verify with pre-commit
       uses: pre-commit/[email protected]