Merge pull request #157 from gofr-dev/FIX/intconversion

Add check for uint16 bounds in Azure Filestore

Author: aryanmehrotra

pkg/file/azure.go

@@ -3,6 +3,7 @@ package file
 import (
 	"context"
 	"fmt"
+	"math"
 	"math/rand"
 	"net/url"
 	"os"
@@ -62,7 +63,7 @@ func newAzureFile(c *AzureConfig, filename string, mode Mode) (*azure, error) {
 			return nil, err
 		}
 
-		azFile.parallelism = uint16(pl)
+		azFile.parallelism = validateAndConvertToUint16(pl)
 	}
 
 	return azFile, nil
@@ -100,3 +101,11 @@ func randomString() string {
 	r := rand.New(rand.NewSource(time.Now().UnixNano())) //nolint:gosec //  Use of weak random number generator
 	return strconv.Itoa(r.Int())
 }
+
+func validateAndConvertToUint16(num int) uint16 {
+	if num >= 0 && num <= math.MaxUint16 {
+		return uint16(num)
+	}
+
+	return uint16(0)
+}

pkg/file/azure_test.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"encoding/base64"
 	"errors"
+	"math"
 	"net/url"
 	"strconv"
 	"testing"
@@ -102,6 +103,26 @@ func Test_azure_push(t *testing.T) {
 	_ = localFile.Close()
 }
 
+func TestValidateAndConvertToUint16(t *testing.T) {
+	tests := []struct {
+		desc   string
+		input  int
+		output uint16
+	}{
+		{"less than 0", -1, uint16(0)},
+		{"is 0", 0, uint16(0)},
+		{"is max uint16", math.MaxUint16, uint16(math.MaxUint16)},
+		{"in uint16 range", 10, uint16(10)},
+		{"greater than uint16 range", math.MaxUint16 + 1, uint16(0)},
+	}
+
+	for _, tc := range tests {
+		result := validateAndConvertToUint16(tc.input)
+
+		assert.Equal(t, tc.output, result)
+	}
+}
+
 func Test_azure_fetch(t *testing.T) {
 	testPipelineMock := testPipeline{}