add test for redis and sql datasource (#352)

Author: Umang01-hash

pkg/gofr/datasource/redis/health_test.go

@@ -40,3 +40,19 @@ func TestRedis_HealthHandlerError(t *testing.T) {
 		Details: map[string]interface{}{"error": "section (Stats) is not supported", "host": s.Host() + ":" + s.Port()},
 	}, health)
 }
+
+func TestRedisHealth_WithoutRedis(t *testing.T) {
+	client := Redis{
+		Client: nil,
+		logger: testutil.NewMockLogger(testutil.ERRORLOG),
+		config: &Config{
+			HostName: "localhost",
+			Port:     2003,
+		},
+	}
+
+	health := client.HealthCheck()
+
+	assert.Equal(t, health.Status, datasource.StatusDown)
+	assert.Equal(t, health.Details["error"], "redis not connected")
+}

pkg/gofr/datasource/redis/redis_test.go

@@ -13,6 +13,33 @@ import (
 	"gofr.dev/pkg/gofr/testutil"
 )
 
+func Test_NewClient_HostNameMissing(t *testing.T) {
+	ctrl := gomock.NewController(t)
+	defer ctrl.Finish()
+
+	mockLogger := testutil.NewMockLogger(testutil.ERRORLOG)
+	mockMetrics := NewMockMetrics(ctrl)
+	mockConfig := testutil.NewMockConfig(map[string]string{"REDIS_HOST": ""})
+
+	client := NewClient(mockConfig, mockLogger, mockMetrics)
+	assert.Nil(t, client, "Test_NewClient_HostNameMissing Failed! Expected redis client to be nil")
+}
+
+func Test_NewClient_InvalidPort(t *testing.T) {
+	ctrl := gomock.NewController(t)
+	defer ctrl.Finish()
+
+	mockLogger := testutil.NewMockLogger(testutil.ERRORLOG)
+	mockMetrics := NewMockMetrics(ctrl)
+	mockConfig := testutil.NewMockConfig(map[string]string{"REDIS_HOST": "localhost",
+		"REDIS_PORT": "&&^%%^&*"})
+
+	mockMetrics.EXPECT().RecordHistogram(gomock.Any(), "app_redis_stats", gomock.Any(), "type", "ping")
+
+	client := NewClient(mockConfig, mockLogger, mockMetrics)
+	assert.Nil(t, client.Client, "Test_NewClient_InvalidPort Failed! Expected redis client to be nil")
+}
+
 func TestRedis_QueryLogging(t *testing.T) {
 	ctrl := gomock.NewController(t)
 	defer ctrl.Finish()

pkg/gofr/datasource/sql/sql_test.go

@@ -1,13 +1,77 @@
 package sql
 
 import (
+	"strings"
 	"testing"
 
+	"go.uber.org/mock/gomock"
+
 	"github.com/stretchr/testify/assert"
 
 	"gofr.dev/pkg/gofr/testutil"
 )
 
+func TestNewSQL_ErrorCase(t *testing.T) {
+	ctrl := gomock.NewController(t)
+
+	expectedLog := "could not connect with 'testuser' user to database 'localhost:3306'  error"
+
+	mockConfig := testutil.NewMockConfig(map[string]string{
+		"DB_DIALECT":  "mysql",
+		"DB_HOST":     "localhost",
+		"DB_USER":     "testuser",
+		"DB_PASSWORD": "testpassword",
+		"DB_PORT":     "3306",
+		"DB_NAME":     "testdb",
+	})
+
+	testLogs := testutil.StderrOutputForFunc(func() {
+		mockLogger := testutil.NewMockLogger(testutil.ERRORLOG)
+		mockMetrics := NewMockMetrics(ctrl)
+
+		NewSQL(mockConfig, mockLogger, mockMetrics)
+	})
+
+	if !strings.Contains(testLogs, expectedLog) {
+		t.Errorf("TestNewSQL_ErrorCase Failed! Expcted error log doesn't match actual.")
+	}
+}
+
+func TestNewSQL_InvalidDialect(t *testing.T) {
+	ctrl := gomock.NewController(t)
+
+	mockConfig := testutil.NewMockConfig(map[string]string{
+		"DB_DIALECT": "abc",
+		"DB_HOST":    "localhost",
+	})
+
+	testLogs := testutil.StderrOutputForFunc(func() {
+		mockLogger := testutil.NewMockLogger(testutil.ERRORLOG)
+		mockMetrics := NewMockMetrics(ctrl)
+
+		NewSQL(mockConfig, mockLogger, mockMetrics)
+	})
+
+	if !strings.Contains(testLogs, errUnsupportedDialect.Error()) {
+		t.Errorf("TestNewSQL_ErrorCase Failed! Expcted error log doesn't match actual.")
+	}
+}
+
+func TestNewSQL_InvalidConfig(t *testing.T) {
+	ctrl := gomock.NewController(t)
+
+	mockConfig := testutil.NewMockConfig(map[string]string{
+		"DB_DIALECT": "",
+	})
+
+	mockLogger := testutil.NewMockLogger(testutil.ERRORLOG)
+	mockMetrics := NewMockMetrics(ctrl)
+
+	db := NewSQL(mockConfig, mockLogger, mockMetrics)
+
+	assert.Nil(t, db, "TestNewSQL_InvalidConfig. expected db to be nil.")
+}
+
 func TestSQL_GetDBConfig(t *testing.T) {
 	mockConfig := testutil.NewMockConfig(map[string]string{
 		"DB_DIALECT":  "mysql",