Skip to content

Commit 8d5269f

Browse files
committed
code-quality fix
1 parent 742a3a3 commit 8d5269f

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

pkg/gofr/factory.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,6 @@ func New() *App {
5858
}
5959

6060
app.grpcServer, err = newGRPCServer(app.container, port, app.Config)
61-
if err != nil {
62-
app.container.Logger.Fatalf("failed to create gRPC server: %v", err)
63-
}
6461

6562
app.subscriptionManager = newSubscriptionManager(app.container)
6663

pkg/gofr/grpc.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ func (g *grpcServer) Run(c *container.Container) {
139139
if g.server == nil {
140140
if err := g.createServer(); err != nil {
141141
c.Logger.Fatalf("failed to create gRPC server: %v", err)
142-
c.Metrics().IncrementCounter(ctx, "grpc_server_errors_total")
142+
c.Metrics().IncrementCounter(context.Background(), "grpc_server_errors_total")
143143
return
144144
}
145145
}
@@ -151,7 +151,7 @@ func (g *grpcServer) Run(c *container.Container) {
151151
listener, err := net.Listen("tcp", addr)
152152
if err != nil {
153153
c.Logger.Errorf("error in starting gRPC server at %s: %s", addr, err)
154-
c.Metrics().IncrementCounter(ctx, "grpc_server_errors_total")
154+
c.Metrics().IncrementCounter(context.Background(), "grpc_server_errors_total")
155155
c.Metrics().SetGauge("grpc_server_status", 0)
156156
return
157157
}
@@ -160,7 +160,7 @@ func (g *grpcServer) Run(c *container.Container) {
160160

161161
if err := g.server.Serve(listener); err != nil {
162162
c.Logger.Errorf("error in starting gRPC server at %s: %s", addr, err)
163-
c.Metrics().IncrementCounter(ctx, "grpc_server_errors_total")
163+
c.Metrics().IncrementCounter(context.Background(), "grpc_server_errors_total")
164164
c.Metrics().SetGauge("grpc_server_status", 0)
165165
return
166166
}
@@ -204,7 +204,7 @@ func (a *App) RegisterService(desc *grpc.ServiceDesc, impl any) {
204204
a.container.Logger.Infof("registering gRPC Server: %s", desc.ServiceName)
205205
a.grpcServer.server.RegisterService(desc, impl)
206206

207-
a.container.Metrics().IncrementCounter(ctx, "grpc_services_registered_total")
207+
a.container.Metrics().IncrementCounter(context.Background(), "grpc_services_registered_total")
208208

209209
err := injectContainer(impl, a.container)
210210
if err != nil {

0 commit comments

Comments
 (0)