added traces and metrics

Author: Suryakantdsa

pkg/gofr/datasource/file/gcs/file.go

@@ -1,6 +1,7 @@
 package gcs
 
 import (
+	"context"
 	"errors"
 	"io"
 	"time"
@@ -147,4 +148,6 @@ func (f *GCSFile) sendOperationStats(fl *FileLog, startTime time.Time) {
 	fl.Duration = duration
 
 	f.logger.Debug(fl)
+	f.metrics.RecordHistogram(context.Background(), appFTPStats, float64(duration),
+		"type", fl.Operation, "status", clean(fl.Status))
 }

pkg/gofr/datasource/file/gcs/file_parse.go

@@ -21,6 +21,7 @@ var (
 )
 
 const (
+	appFTPStats   = "app_ftp_stats"
 	statusErr     = "ERROR"
 	statusSuccess = "SUCCESS"
 )

pkg/gofr/datasource/file/gcs/fs_dir_test.go

@@ -72,6 +72,8 @@ func Test_Mkdir_GCS(t *testing.T) {
 	mockLogger.EXPECT().Debugf(gomock.Any()).AnyTimes()
 	mockLogger.EXPECT().Debug(gomock.Any()).AnyTimes()
 	mockLogger.EXPECT().Errorf(gomock.Any(), gomock.Any()).AnyTimes()
+	mockMetrics.EXPECT().RecordHistogram(gomock.Any(), appFTPStats, gomock.Any(),
+		"type", gomock.Any(), "status", gomock.Any()).AnyTimes()
 
 	tests := []testCase{
 		{
@@ -136,6 +138,8 @@ func Test_ReadDir_GCS(t *testing.T) {
 	mockLogger.EXPECT().Logf(gomock.Any(), gomock.Any()).AnyTimes()
 	mockLogger.EXPECT().Debug(gomock.Any()).AnyTimes()
 	mockLogger.EXPECT().Errorf(gomock.Any(), gomock.Any()).AnyTimes()
+	mockMetrics.EXPECT().RecordHistogram(gomock.Any(), appFTPStats, gomock.Any(),
+		"type", gomock.Any(), "status", gomock.Any()).AnyTimes()
 
 	for _, tt := range getReadDirTestCases(mockGCS) {
 		t.Run(tt.name, func(t *testing.T) {

pkg/gofr/datasource/file/gcs/fs_test.go

@@ -49,6 +49,8 @@ func Test_CreateFile(t *testing.T) {
 	mockLogger.EXPECT().Logf(gomock.Any(), gomock.Any()).AnyTimes()
 	mockLogger.EXPECT().Errorf(gomock.Any(), gomock.Any()).AnyTimes()
 	mockLogger.EXPECT().Debug(gomock.Any()).AnyTimes()
+	mockMetrics.EXPECT().RecordHistogram(gomock.Any(), appFTPStats, gomock.Any(),
+		"type", gomock.Any(), "status", gomock.Any()).AnyTimes()
 
 	tests := []testCase{
 		{
@@ -122,6 +124,8 @@ func Test_Remove_GCS(t *testing.T) {
 	mockLogger.EXPECT().Logf(gomock.Any(), gomock.Any()).AnyTimes()
 	mockLogger.EXPECT().Errorf(gomock.Any(), gomock.Any()).AnyTimes()
 	mockLogger.EXPECT().Debug(gomock.Any()).AnyTimes()
+	mockMetrics.EXPECT().RecordHistogram(gomock.Any(), appFTPStats, gomock.Any(),
+		"type", gomock.Any(), "status", gomock.Any()).AnyTimes()
 
 	mockGCS.EXPECT().
 		DeleteObject(gomock.Any(), "abc/a1.txt").
@@ -211,6 +215,8 @@ func TestRenameFile(t *testing.T) {
 	mockLogger.EXPECT().Debug(gomock.Any()).AnyTimes()
 	mockLogger.EXPECT().Errorf(gomock.Any(), gomock.Any()).AnyTimes()
 	mockLogger.EXPECT().Debug(gomock.Any(), gomock.Any()).AnyTimes()
+	mockMetrics.EXPECT().RecordHistogram(gomock.Any(), appFTPStats, gomock.Any(),
+		"type", gomock.Any(), "status", gomock.Any()).AnyTimes()
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
@@ -290,6 +296,8 @@ func Test_StatFile_GCS(t *testing.T) {
 			mockLogger.EXPECT().Errorf(gomock.Any(), gomock.Any()).AnyTimes()
 
 			mockGCS.EXPECT().StatObject(gomock.Any(), tt.filePath).Return(tt.mockAttr, tt.mockError)
+			mockMetrics.EXPECT().RecordHistogram(gomock.Any(), appFTPStats, gomock.Any(),
+				"type", gomock.Any(), "status", gomock.Any()).AnyTimes()
 
 			res, err := fs.Stat(tt.filePath)
 			if tt.expectError {
@@ -329,6 +337,8 @@ func Test_Stat_FileAndDir(t *testing.T) {
 	mockLogger.EXPECT().Logf(gomock.Any(), gomock.Any()).AnyTimes()
 	mockLogger.EXPECT().Debug(gomock.Any()).AnyTimes()
 	mockLogger.EXPECT().Errorf(gomock.Any(), gomock.Any()).AnyTimes()
+	mockMetrics.EXPECT().RecordHistogram(gomock.Any(), appFTPStats, gomock.Any(),
+		"type", gomock.Any(), "status", gomock.Any()).AnyTimes()
 
 	fileName := "documents/testfile.txt"
 	fileAttrs := &storage.ObjectAttrs{

pkg/gofr/datasource/file/gcs/interface.go

@@ -24,15 +24,13 @@ type gcsClientImpl struct {
 }
 
 type gcsClient interface {
-	// NewWriter(ctx context.Context, name string) *storage.Writer
 	NewWriter(ctx context.Context, name string) io.WriteCloser
 	NewReader(ctx context.Context, name string) (*storage.Reader, error)
 	DeleteObject(ctx context.Context, name string) error
 	CopyObject(ctx context.Context, src, dst string) error
 	ListObjects(ctx context.Context, prefix string) ([]string, error)
 	ListDir(ctx context.Context, prefix string) ([]*storage.ObjectAttrs, []string, error)
 	StatObject(ctx context.Context, name string) (*storage.ObjectAttrs, error)
-	// GetSignedURL(ctx context.Context, object string, expiry time.Duration) (string, error)
 }
 
 type Metrics interface {