Discussion: Gofr v2 Goals and Scope

[gizmo-rt]

List of proposed changes in Gofr V2

[vipul-rawat]

Improve logging - reduce time and memory it takes to log.

[coolwednesday]

I have been working on this recently. Has been able to double the performance. We can have this discussion in the next community call, if you are up for it.

[aryanmehrotra]

Error response restructure

[coolwednesday]

@aryanmehrotra, Can you let me know specifically what more should GoFr improve in error responses ?

[akshat-kumar-singhal]

Change HTTP AddOption to an interceptor type of implementation.

type Interceptor interface {
  func processRequest(context.Context, method, path string, queryParams map[string]any, headers map[string]string) (path string, queryParams map[string]any, headers map[string]string, error)
}

For the inceptors registered in HTTP Service, processRequest would be called sequentially - it'll update the headers/path/queryParams as needed, providing the same level of control that we have through new structs implementing HTTP interface and thereby duplicating a lot of code. Also, in case the request has to be cancelled/blocked i.e. circuitbreaker/rate limiter type of behaviour, the interceptor processRequest would return an error - not nil error from processRequest would stop the further processing.

[akshat-kumar-singhal]

Move Auth related files in separate package - changes were done in #2373 but not merged due to breaking changes