Skip to content

Update README.md#12

Open
girishbharambe wants to merge 1 commit intoupdate-sub-modulefrom
readme-1
Open

Update README.md#12
girishbharambe wants to merge 1 commit intoupdate-sub-modulefrom
readme-1

Conversation

@girishbharambe
Copy link
Contributor

No description provided.

$ mvn spring-boot:run
```

You can visit the URL from `preview` command or [http://localhost:8080/](http://localhost:8080/) to check your extension.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@girishbharambe Here, we have new functionality of preview command. Preview command internally install and start server. It will also update base URL. Please check new functionality and update the instructions.
FYI: @vivek-gofynd

fdk extension preview
$ fdk extension preview
```
This command will provide a partner’s panel URL where you can interact with your extension. For more information, please read this [guide](https://github.com/gofynd/fdk-cli?tab=readme-ov-file#extension-commands).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@girishbharambe Any reason for removing cli readme ref?
FYI: @vivek-gofynd

Build frontend.

Using yarn:
* Build front-end files
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@girishbharambe build section could be below "Run the application" section.
Why we have added everything in in getting started? Should we have separate section for init & preview, Build Instructions and then Docker Instructions.
FYI: @vivek-gofynd

![Spring](https://img.shields.io/badge/spring-%236DB33F.svg?style=for-the-badge&logo=spring&logoColor=white)
![Redis](https://img.shields.io/badge/redis-%23DD0031.svg?style=for-the-badge&logo=redis&logoColor=white)
![Java](https://img.shields.io/badge/java-%23ED8B00.svg?style=for-the-badge&logo=openjdk&logoColor=white)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vivek-gofynd Should we add node/npm here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants