Override secret pasword for internal database

[containeers]

The current internal postgres password are shared through multiple secrets. For internal there is no way to override an existing secret

https://github.com/goharbor/harbor-helm/blob/main/templates/database/database-ss.yaml#L97

envFrom: - secretRef: name: "{{ template "harbor.database" . }}"

Add a logic to override the password.

[MinerYang]

Hi @containeers ,

Could you elaborate more? We don't override anything, unless the secret is not existing.

[MinerYang]

Hi @containeers ,

Could you provide the values.yaml configuration file file you deploy harbor?
When you saying internal postgres, was it means harbor-internal scope or your cluster-internal scope?

[containeers]

Hi @MinerYang

Please refer to line 97 in the following file:
https://github.com/goharbor/harbor-helm/blob/main/templates/database/database-ss.yaml#L97

Currently, the code is:

envFrom:
  - secretRef:
      name: "{{ template "harbor.database" . }}"

Can this be updated to:

envFrom:
  - secretRef:
      name: "{{ default (include "harbor.database" .) .Values.database.internal.existingSecret }}"

This change would allow us to inject an external secret by specifying our own secret name via .Values.database.internal.existingSecret, such as when using an external secret manager.

Overall the whole helm chart doesnt manage secret well, it is more cumbersome.

[ildoc]

seems very similar to #1783

[github-actions]

This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days.

[github-actions]

This issue was closed because it has been stalled for 30 days with no activity. If this issue is still relevant, please re-open a new issue.