set Content-Length header before writing body

ajatprabha · ajatprabha · commit 7664d78b3c13 · 2020-11-04T17:04:48.000+05:30
diff --git a/internal/handler/image.go b/internal/handler/image.go
@@ -58,8 +58,8 @@ func ImageHandler(deps *service.Dependencies) http.HandlerFunc {
 		w.Header().Set(CacheControlHeader, fmt.Sprintf("public,max-age=%d", config.CacheTime()))
 		// Ref to Google CDN we support: https://cloud.google.com/cdn/docs/caching#cacheability
 		w.Header().Set(VaryHeader, "Accept")
+		w.Header().Set(ContentLengthHeader, fmt.Sprintf("%d", len(data)))
 
-		cl, _ := w.Write(data)
-		w.Header().Set(ContentLengthHeader, fmt.Sprintf("%d", cl))
+		_, _ = w.Write(data)
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -58,8 +58,8 @@ func ImageHandler(deps *service.Dependencies) http.HandlerFunc {`
`58`	`58`	`w.Header().Set(CacheControlHeader, fmt.Sprintf("public,max-age=%d", config.CacheTime()))`
`59`	`59`	`// Ref to Google CDN we support: https://cloud.google.com/cdn/docs/caching#cacheability`
`60`	`60`	`w.Header().Set(VaryHeader, "Accept")`
	`61`	`+ w.Header().Set(ContentLengthHeader, fmt.Sprintf("%d", len(data)))`
`61`	`62`
`62`		`- cl, _ := w.Write(data)`
`63`		`- w.Header().Set(ContentLengthHeader, fmt.Sprintf("%d", cl))`
	`63`	`+ _, _ = w.Write(data)`
`64`	`64`	`}`
`65`	`65`	`}`