refactor(playlist_page): remove paging controller and related logic for simplified playlist display (fixes: #776)

Author: gokadzev

lib/screens/playlist_page.dart

@@ -20,12 +20,10 @@
  */
 
 import 'dart:async';
-import 'dart:math';
 
 import 'package:fluentui_system_icons/fluentui_system_icons.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter/services.dart';
-import 'package:infinite_scroll_pagination/infinite_scroll_pagination.dart';
 import 'package:musify/extensions/l10n.dart';
 import 'package:musify/main.dart';
 import 'package:musify/services/common_services.dart';
@@ -73,9 +71,6 @@ class _PlaylistPageState extends State<PlaylistPage> {
   late final List<dynamic>
   _originalPlaylistList; // Keep original order separately
 
-  final int _itemsPerPage = 35;
-  late final PagingController<int, dynamic> _pagingController;
-
   late final playlistLikeStatus = ValueNotifier<bool>(
     isPlaylistAlreadyLiked(widget.playlistId),
   );
@@ -104,24 +99,11 @@ class _PlaylistPageState extends State<PlaylistPage> {
   @override
   void initState() {
     super.initState();
-
-    _pagingController = PagingController<int, dynamic>(
-      getNextPageKey: (state) {
-        final source = _sourceList;
-        final totalCount = source.length;
-        final currentlyLoaded = state.items?.length ?? 0;
-        if (currentlyLoaded >= totalCount) return null;
-        return currentlyLoaded;
-      },
-      fetchPage: _fetchPage,
-    );
-
     _initializePlaylist();
   }
 
   @override
   void dispose() {
-    _pagingController.dispose();
     super.dispose();
   }
 
@@ -167,17 +149,6 @@ class _PlaylistPageState extends State<PlaylistPage> {
     }
   }
 
-  Future<List<dynamic>> _fetchPage(int pageKey) async {
-    try {
-      final source = _sourceList;
-      final startIndex = pageKey;
-      final endIndex = min(startIndex + _itemsPerPage, source.length);
-      return source.sublist(startIndex, endIndex);
-    } catch (error) {
-      rethrow;
-    }
-  }
-
   @override
   Widget build(BuildContext context) {
     return Scaffold(
@@ -189,30 +160,28 @@ class _PlaylistPageState extends State<PlaylistPage> {
         ),
       ),
       body: _playlist != null
-          ? PagingListener(
-              controller: _pagingController,
-              builder: (context, state, fetchNextPage) => CustomScrollView(
-                slivers: [
-                  SliverToBoxAdapter(child: _buildHeaderSection()),
-                  if (_playlist['list'].isNotEmpty) ...[
-                    SliverPadding(
-                      padding: commonListViewBottomPadding,
-                      sliver: PagedSliverList(
-                        state: state,
-                        fetchNextPage: fetchNextPage,
-                        builderDelegate: PagedChildBuilderDelegate<dynamic>(
-                          itemBuilder: (context, item, index) {
-                            final isRemovable =
-                                _playlist['source'] == 'user-created';
-                            return _buildSongListItem(item, index, isRemovable);
-                          },
-                        ),
-                      ),
+          ? CustomScrollView(
+              slivers: [
+                SliverToBoxAdapter(child: _buildHeaderSection()),
+                if ((_playlist['list'] as List).isNotEmpty) ...[
+                  SliverPadding(
+                    padding: commonListViewBottomPadding,
+                    sliver: SliverList.builder(
+                      itemCount: _sourceList.length,
+                      itemBuilder: (context, index) {
+                        final isRemovable =
+                            _playlist['source'] == 'user-created';
+                        return _buildSongListItem(
+                          _sourceList[index],
+                          index,
+                          isRemovable,
+                        );
+                      },
                     ),
-                  ] else
-                    const SliverFillRemaining(child: SizedBox.expand()),
-                ],
-              ),
+                  ),
+                ] else
+                  const SliverFillRemaining(child: SizedBox.expand()),
+              ],
             )
           : SizedBox(
               height: MediaQuery.sizeOf(context).height - 100,
@@ -293,14 +262,8 @@ class _PlaylistPageState extends State<PlaylistPage> {
           const SizedBox(height: 16),
           PlaylistSearchBar(
             query: _searchQuery,
-            onChanged: (value) {
-              setState(() => _searchQuery = value);
-              _pagingController.refresh();
-            },
-            onCleared: () {
-              setState(() => _searchQuery = '');
-              _pagingController.refresh();
-            },
+            onChanged: (value) => setState(() => _searchQuery = value),
+            onCleared: () => setState(() => _searchQuery = ''),
           ),
         ],
         const SizedBox(height: 16),
@@ -555,7 +518,6 @@ class _PlaylistPageState extends State<PlaylistPage> {
           }
         });
       }
-      _pagingController.refresh();
     } else {
       final resolvedId = _playlist['ytid']?.toString() ?? widget.playlistId;
       final updatedPlaylist = await getPlaylistInfoForWidget(resolvedId);
@@ -568,19 +530,15 @@ class _PlaylistPageState extends State<PlaylistPage> {
             );
           }
         });
-        _pagingController.refresh();
       }
     }
   }
 
-  void _updateSongsListOnRemove(int indexOfRemovedSong) {
-    final items = _pagingController.items ?? [];
-    if (indexOfRemovedSong >= items.length) return;
-
-    final dynamic songToRemove = items[indexOfRemovedSong];
+  void _updateSongsListOnRemove(int indexOfRemovedSong, dynamic songToRemove) {
     _originalPlaylistList.removeWhere((s) => s['ytid'] == songToRemove['ytid']);
     final playlistId = _playlist['ytid'];
     if (mounted) {
+      setState(() {});
       showToastWithButton(
         context,
         context.l10n!.songRemoved,
@@ -592,16 +550,14 @@ class _PlaylistPageState extends State<PlaylistPage> {
             songToRemove,
             indexToInsert: indexOfRemovedSong,
           );
-          _pagingController.refresh();
+          if (mounted) setState(() {});
         },
       );
     } else {
       logger.log(
         '(_updateSongsListOnRemove): Widget not mounted, cannot show undo toast.',
       );
     }
-
-    _pagingController.refresh();
   }
 
   String _getSortTypeDisplayText(PlaylistSortType type) {
@@ -634,14 +590,10 @@ class _PlaylistPageState extends State<PlaylistPage> {
         _playlist['list'] = playlist;
         break;
     }
-
-    // Reset paging controller to top
-    _pagingController.refresh();
   }
 
   Widget _buildSongListItem(dynamic song, int index, bool isRemovable) {
-    final items = _pagingController.items ?? [];
-    final totalItems = items.length;
+    final totalItems = _sourceList.length;
     final borderRadius = getItemBorderRadius(index, totalItems);
     final isUserCreatedPlaylist = _playlist?['source'] == 'user-created';
     final playlistId = isUserCreatedPlaylist ? _playlist!['ytid'] : null;
@@ -660,7 +612,7 @@ class _PlaylistPageState extends State<PlaylistPage> {
                 song,
                 removeOneAtIndex: index,
               )) {
-                _updateSongsListOnRemove(index);
+                _updateSongsListOnRemove(index, song);
               }
             }
           : null,

pubspec.lock

@@ -275,14 +275,6 @@ packages:
       url: "https://pub.dev"
     source: hosted
     version: "2.0.33"
-  flutter_staggered_grid_view:
-    dependency: transitive
-    description:
-      name: flutter_staggered_grid_view
-      sha256: "19e7abb550c96fbfeb546b23f3ff356ee7c59a019a651f8f102a4ba9b7349395"
-      url: "https://pub.dev"
-    source: hosted
-    version: "0.7.0"
   flutter_test:
     dependency: "direct dev"
     description: flutter
@@ -373,14 +365,6 @@ packages:
       url: "https://pub.dev"
     source: hosted
     version: "4.1.2"
-  infinite_scroll_pagination:
-    dependency: "direct main"
-    description:
-      name: infinite_scroll_pagination
-      sha256: b0d28e37cd8f62490ff6aef63f9db93d4c78b7f11b7c6b26f33c69d8476fda78
-      url: "https://pub.dev"
-    source: hosted
-    version: "5.1.1"
   intl:
     dependency: "direct main"
     description:
@@ -633,14 +617,6 @@ packages:
     description: flutter
     source: sdk
     version: "0.0.0"
-  sliver_tools:
-    dependency: transitive
-    description:
-      name: sliver_tools
-      sha256: eae28220badfb9d0559207badcbbc9ad5331aac829a88cb0964d330d2a4636a6
-      url: "https://pub.dev"
-    source: hosted
-    version: "0.2.12"
   source_span:
     dependency: transitive
     description:

pubspec.yaml

@@ -29,7 +29,6 @@ dependencies:
   hive_flutter: ^1.1.0
   html: ^0.15.6
   http: ^1.6.0
-  infinite_scroll_pagination: ^5.1.1
   intl: ^0.20.2
   just_audio: 0.10.5
   path_provider: ^2.1.5