Add support for TIFF images on darwin #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the default image format for the clipboard on macOS is tiff (that is, when you click "Copy Image" on any meny on macOS it will copy the image data in the TIFF format), it seems useful to add support for this in the `clipboard_darwin.m` file. It is pretty simple: if the format is not PNG, we try to read TIFF; then, if successful, we convert it to a bitmap and, finally, to PNG. In this manner we return the same PNG data, and the user does not neet do modify his code at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the default image format for the clipboard on macOS is tiff (that is, when you click "Copy Image" on any meny on macOS it will copy the image data in the TIFF format), it seems useful to add support for this in the
clipboard_darwin.mfile.It is pretty simple: if the format is not PNG, we try to read TIFF; then, if successful, we convert it to a bitmap and, finally, to PNG. In this manner we return the same PNG data, and the user does not neet do modify his code at all.