all: remove external executable dependency 'goimports' (#11)

Author: katsusan

go.mod

@@ -6,5 +6,6 @@ require (
 	github.com/gin-gonic/gin v1.6.2
 	github.com/google/uuid v1.1.1
 	github.com/sirupsen/logrus v1.5.0
+	golang.org/x/tools v0.0.0-20180917221912-90fa682c2a6e
 	gopkg.in/yaml.v2 v2.2.8
 )

go.sum

@@ -43,11 +43,11 @@ github.com/ugorji/go v1.1.7 h1:/68gy2h+1mWMrwZFeD1kQialdSzAb432dtpeJ42ovdo=
 github.com/ugorji/go v1.1.7/go.mod h1:kZn38zHttfInRq0xu/PH0az30d+z6vm202qpg1oXVMw=
 github.com/ugorji/go/codec v1.1.7 h1:2SvQaVZ1ouYrrKKwoSk2pzd4A9evlKJb9oTL+OaLUSs=
 github.com/ugorji/go/codec v1.1.7/go.mod h1:Ax+UKWsSmolVDwsd+7N3ZtXu+yMGCf907BLYF3GoBXY=
-golang.org/x/sys v0.0.0-20190422165155-953cdadca894 h1:Cz4ceDQGXuKRnVBDTS23GTn/pU5OE2C0WrNTOYK1Uuc=
 golang.org/x/sys v0.0.0-20190422165155-953cdadca894/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/sys v0.0.0-20200116001909-b77594299b42 h1:vEOn+mP2zCOVzKckCZy6YsCtDblrpj/w7B9nxGNELpg=
 golang.org/x/sys v0.0.0-20200116001909-b77594299b42/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/text v0.3.2/go.mod h1:bEr9sfX3Q8Zfm5fL9x+3itogRgK3+ptLWKqgva+5dAk=
+golang.org/x/tools v0.0.0-20180917221912-90fa682c2a6e h1:FDhOuMEY4JVRztM/gsbk+IKUQ8kj74bxZrgw87eMMVc=
 golang.org/x/tools v0.0.0-20180917221912-90fa682c2a6e/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=

src/config/config.go

@@ -5,12 +5,10 @@
 package config
 
 import (
-	"bytes"
 	"flag"
 	"fmt"
 	"io/ioutil"
 	"os"
-	"os/exec"
 
 	"github.com/gin-gonic/gin"
 	"github.com/sirupsen/logrus"
@@ -59,21 +57,9 @@ Usage:
 	if err != nil {
 		logrus.Fatalf("fatal: fail to parse configuration file: %v", err)
 	}
-	commandCheck()
 	gin.SetMode(conf.Mode)
 
 	logrus.SetFormatter(&logrus.TextFormatter{})
 	logrus.SetReportCaller(false)
 	logrus.Infof("load config file: %q", f)
 }
-
-func commandCheck() {
-	// check goimports
-	cmd := exec.Command("goimports", "-h")
-	cmd.Stderr = &bytes.Buffer{}
-	err := cmd.Run()
-	if err != nil && cmd.Stderr.(*bytes.Buffer).String() == "" {
-		logrus.Fatalf("fatal: goimports commond not found: %v", err)
-		return
-	}
-}

src/route/api.go

@@ -20,6 +20,7 @@ import (
 	"github.com/gin-gonic/gin"
 	"github.com/google/uuid"
 	"golang.design/x/ssaplayground/src/config"
+	"golang.org/x/tools/imports"
 )
 
 // PingInput is a a reserved structure
@@ -92,20 +93,21 @@ func BuildSSA(c *gin.Context) {
 	} else {
 		buildFile = filepath.Join(path, "/main_test.go")
 	}
-	err = ioutil.WriteFile(buildFile, []byte(in.Code), os.ModePerm)
+
+	// 3.1 goimports
+	importedCode, err := autoimports([]byte(in.Code))
 	if err != nil {
 		os.Remove(path)
-		out.Msg = fmt.Sprintf("cannot save your code, err: \n%v", err)
-		c.JSON(http.StatusInternalServerError, out)
+		out.Msg = fmt.Sprintf("cannot run autoimports for your code, err: \n%v", err)
+		c.JSON(http.StatusBadRequest, out)
 		return
 	}
 
-	// 3.1 goimports
-	err = autoimports(buildFile)
+	err = ioutil.WriteFile(buildFile, importedCode, os.ModePerm)
 	if err != nil {
 		os.Remove(path)
-		out.Msg = fmt.Sprintf("cannot run autoimports for your code, err: \n%v", err)
-		c.JSON(http.StatusBadRequest, out)
+		out.Msg = fmt.Sprintf("cannot save your code, err: \n%v", err)
+		c.JSON(http.StatusInternalServerError, out)
 		return
 	}
 
@@ -189,16 +191,18 @@ func isPackageTest(code string) bool {
 	return re.FindString(code) != ""
 }
 
-func autoimports(outf string) error {
-	cmd := exec.Command("goimports", "-w", outf)
-	cmd.Stderr = &bytes.Buffer{}
-	err := cmd.Run()
+func autoimports(code []byte) ([]byte, error) {
+	out, err := imports.Process("", code, &imports.Options{
+		Fragment:  true,
+		AllErrors: true,
+		Comments:  true,
+		TabIndent: true,
+		TabWidth:  8,
+	})
 	if err != nil {
-		msg := cmd.Stderr.(*bytes.Buffer).String()
-		msg = strings.ReplaceAll(msg, filepath.Dir(outf), "$GOSSAPATH")
-		return errors.New(msg)
+		return nil, err
 	}
-	return nil
+	return out, nil
 }
 
 func initModules(path string) error {