Tests

Author: dsyers

Makefile

@@ -38,7 +38,6 @@ test:
 	@mkdir $(COVERAGE_DIR)
 	make test-with-flags TEST_FLAGS='-v -race -covermode atomic -coverprofile $$(COVERAGE_DIR)/combined.txt -bench=. -benchmem -timeout 20m'
 
-
 test-with-flags:
 	@echo SOURCE: $(SOURCE)
 	@echo DATABASE_TEST: $(DATABASE_TEST)

database/cassandra/cassandra.go

@@ -287,7 +287,7 @@ func (c *Cassandra) Run(migration io.Reader) error {
 		// TODO: cast to Cassandra error and get line number
 		return database.Error{OrigErr: err, Err: "migration failed", Query: migr}
 	}
-	if err := c.Trigger(database.TrigRunPre, struct {
+	if err := c.Trigger(database.TrigRunPost, struct {
 		Query string
 	}{Query: string(migr)}); err != nil {
 		return database.Error{OrigErr: err, Err: "failed to trigger RunPost"}

database/cockroachdb/cockroachdb.go

@@ -411,6 +411,7 @@ func (c *CockroachDb) ensureVersionTable() (err error) {
 }
 
 func (c *CockroachDb) ensureLockTable() error {
+
 	// check if lock table exists
 	var count int
 	query := `SELECT COUNT(1) FROM information_schema.tables WHERE table_name = $1 AND table_schema = (SELECT current_schema()) LIMIT 1`

database/testing/migrate_testing.go

@@ -4,6 +4,8 @@
 package testing
 
 import (
+	"github.com/golang-migrate/migrate/v4/database"
+	"reflect"
 	"testing"
 )
 
@@ -28,7 +30,74 @@ func TestMigrateDrop(t *testing.T, m *migrate.Migrate) {
 
 func TestMigrateUp(t *testing.T, m *migrate.Migrate) {
 	t.Log("UP")
+
+	tt := &triggerTest{
+		t: t,
+		m: m,
+		triggered: map[string]bool{
+			migrate.TrigRunMigrationPre:         false,
+			migrate.TrigRunMigrationPost:        false,
+			migrate.TrigRunMigrationVersionPre:  false,
+			migrate.TrigRunMigrationVersionPost: false,
+			database.TrigRunPre:                 false,
+			database.TrigRunPost:                false,
+		},
+	}
+
+	m.Triggers = map[string]func(r migrate.TriggerResponse) error{
+		migrate.TrigRunMigrationPre:         tt.trigMigrationCheck,
+		migrate.TrigRunMigrationPost:        tt.trigMigrationCheck,
+		migrate.TrigRunMigrationVersionPre:  tt.trigMigrationCheck,
+		migrate.TrigRunMigrationVersionPost: tt.trigMigrationCheck,
+	}
+
+	m.AddDatabaseTriggers(map[string]func(response interface{}) error{
+		database.TrigRunPre:  tt.trigDatabaseMigrationCheck,
+		database.TrigRunPost: tt.trigDatabaseMigrationCheck,
+	})
+
 	if err := m.Up(); err != nil {
 		t.Fatal(err)
 	}
+
+	if !tt.triggered[migrate.TrigRunMigrationPre] {
+		t.Fatalf("expected trigger %s to be called, but it was not", migrate.TrigRunMigrationPre)
+	}
+	if !tt.triggered[migrate.TrigRunMigrationPost] {
+		t.Fatalf("expected trigger %s to be called, but it was not", migrate.TrigRunMigrationPost)
+	}
+	if !tt.triggered[migrate.TrigRunMigrationVersionPre] {
+		t.Fatalf("expected trigger %s to be called, but it was not", migrate.TrigRunMigrationVersionPre)
+	}
+	if !tt.triggered[migrate.TrigRunMigrationVersionPost] {
+		t.Fatalf("expected trigger %s to be called, but it was not", migrate.TrigRunMigrationVersionPost)
+	}
+	if !tt.triggered[database.TrigRunPre] {
+		t.Fatalf("expected database trigger %s to be called, but it was not", database.TrigRunPre)
+	}
+	if !tt.triggered[database.TrigRunPost] {
+		t.Fatalf("expected database trigger %s to be called, but it was not", database.TrigRunPost)
+	}
+}
+
+type triggerTest struct {
+	t         *testing.T
+	m         *migrate.Migrate
+	triggered map[string]bool
+}
+
+func (tt *triggerTest) trigMigrationCheck(r migrate.TriggerResponse) error {
+	tt.triggered[r.Trigger] = true
+	return nil
+}
+
+func (tt *triggerTest) trigDatabaseMigrationCheck(response interface{}) error {
+	val := reflect.ValueOf(response)
+	field := val.FieldByName("Trigger")
+	if !field.IsValid() {
+		tt.t.Fatalf("expected response to have a Trigger field, got %T", response)
+	}
+
+	tt.triggered[field.String()] = true
+	return nil
 }

migrate.go

@@ -238,6 +238,10 @@ func (m *Migrate) Trigger(name string, detail interface{}) error {
 	return nil
 }
 
+func (m *Migrate) AddDatabaseTriggers(t map[string]func(response interface{}) error) {
+	m.databaseDrv.AddTriggers(t)
+}
+
 // Close closes the source and the database.
 func (m *Migrate) Close() (source error, database error) {
 	databaseSrvClose := make(chan error)