Skip to content

Commit 0c1a778

Browse files
committed
fix(leak): goroutine leak
redis channel default buffer size is 100 Signed-off-by: Bo-Yi Wu <[email protected]>
1 parent 989c149 commit 0c1a778

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ start the redis cluster, see the [config](./conf/redis.conf)
2020

2121
```sh
2222
# server 01
23-
mkdir server01 && cd server 01 && redis-server redis.conf --port 6379
23+
mkdir server01 && cd server01 && redis-server redis.conf --port 6379
2424
# server 02
25-
mkdir server02 && cd server 02 && redis-server redis.conf --port 6380
25+
mkdir server02 && cd server02 && redis-server redis.conf --port 6380
2626
```
2727

2828
## Example

redis_test.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -260,13 +260,12 @@ func TestGoroutineLeak(t *testing.T) {
260260
assert.NoError(t, err)
261261
q.Start()
262262
time.Sleep(50 * time.Millisecond)
263-
for i := 0; i < 500; i++ {
263+
for i := 0; i < 50; i++ {
264264
m.Message = fmt.Sprintf("foobar: %d", i+1)
265265
assert.NoError(t, q.Queue(m))
266266
}
267267
time.Sleep(1 * time.Second)
268-
q.Shutdown()
269-
q.Wait()
268+
q.Release()
270269
time.Sleep(1 * time.Second)
271270
fmt.Println("number of goroutines:", runtime.NumGoroutine())
272271
}

0 commit comments

Comments
 (0)