Update golangci-lint to v1.28.0 (#49)

Author: pellared

.github/workflows/build.yml

@@ -23,7 +23,7 @@ jobs:
         with:
           go-version: 1.14
       - name: Build
-        run: make all
+        run: make ci
       - name: Upload coverage
         uses: actions/upload-artifact@v2
         with:

.golangci.yml

@@ -3,6 +3,8 @@ linters-settings:
     local-prefixes: github.com/golang-templates/seed
   golint:
     min-confidence: 0
+  govet:
+    check-shadowing: true
   misspell:
     locale: US
   nolintlint:
@@ -33,6 +35,7 @@ linters:
     - depguard
     - dogsled
     - dupl
+    - exportloopref
     - funlen
     - gochecknoglobals
     - gochecknoinits
@@ -44,6 +47,7 @@ linters:
     - godox
     - goerr113
     - gofmt
+    - gofumpt
     - goimports
     - golint
     - gomnd
@@ -56,16 +60,20 @@ linters:
     - misspell
     - nakedret
     - nestif
+    - noctx
     - nolintlint
     - prealloc
     - rowserrcheck
     - scopelint
+    - sqlclosecheck
     - stylecheck
-    # - testpackage
     - unconvert
     - unparam
     - whitespace
     - wsl
+    # don't enable:
+    # - go-header
+    # - testpackage
 
 issues:
   # enable issues excluded by default 

Makefile

@@ -1,8 +1,8 @@
 .DEFAULT_GOAL := help
 
-.PHONY: all
-all: ## full build
-all: install generate build fmt lint test mod-tidy build-snapshot diff
+.PHONY: ci
+all: ## CI build
+all: install generate build lint test mod-tidy build-snapshot diff
 
 .PHONY: dev
 dev: ## fast build
@@ -77,7 +77,7 @@ run: ## go run
 	go run .
 
 .PHONY: docker
-docker: ## run in golang container, example: make docker run="make all"
+docker: ## run in golang container, example: make docker run="make ci"
 	docker run --rm \
 		-v $(CURDIR):/repo $(args) \
 		-w /repo \

go.mod

@@ -3,7 +3,7 @@ module github.com/golang-templates/seed
 go 1.14
 
 require (
-	github.com/golangci/golangci-lint v1.27.0
+	github.com/golangci/golangci-lint v1.28.0
 	github.com/goreleaser/goreleaser v0.138.0
-	golang.org/x/tools v0.0.0-20200608174601-1b747fd94509
+	golang.org/x/tools v0.0.0-20200702044944-0cc1aa72b347
 )