Skip to content

Commit 1dfa65a

Browse files
committed
cmd/bench: run go tests 6 times
benchstat wants 95% CI by default, which requires at least 6 samples. Change-Id: I250255b4d7860892de330e31269184b5e97bc7a6 Reviewed-on: https://go-review.googlesource.com/c/benchmarks/+/623641 Reviewed-by: Michael Knyszek <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
1 parent 70f791b commit 1dfa65a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

cmd/bench/gotest.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ func goTest(tcs []*toolchain) error {
1414
for _, tc := range tcs {
1515
log.Printf("Running Go test benchmarks for %s", tc.Name)
1616
fmt.Printf("toolchain: %s\n", tc.Name)
17-
err := tc.Do("", "test", "-v", "-run=none", "-short", "-bench=.", "-count=5", "golang.org/x/benchmarks/...")
17+
err := tc.Do("", "test", "-v", "-run=none", "-short", "-bench=.", "-count=6", "golang.org/x/benchmarks/...")
1818
if err != nil {
1919
return fmt.Errorf("error running gotest with toolchain %s: %w", tc.Name, err)
2020
}
@@ -68,7 +68,7 @@ func goTestSubrepo(tc *toolchain, subRepo, baselineDir, experimentDir string) er
6868
fmt.Printf("toolchain: %s\n", test.name) // set the toolchain tag
6969

7070
goplsPath := filepath.Join(test.goplsDir, "gopls")
71-
err = tc.Do(benchmarkDir, "test", "-short", "-bench=.", fmt.Sprintf(`-gopls_path=%s`, goplsPath), "-count=5", "-timeout=180m")
71+
err = tc.Do(benchmarkDir, "test", "-short", "-bench=.", fmt.Sprintf(`-gopls_path=%s`, goplsPath), "-count=6", "-timeout=180m")
7272
if err != nil {
7373
return fmt.Errorf("error running sub-repo %s benchmark %q with toolchain %s in dir %s: %w", subRepo, test.name, tc.Name, benchmarkDir, err)
7474
}

0 commit comments

Comments
 (0)