apidiff: handle TypeParam in order to handle generic code

This enables apidiff to handle code that uses generics, whereas currently it
panics when it encounters it.

Change-Id: Ic77561fd4f269d2060da76ccdaab9166ec65e7ca
Reviewed-on: https://go-review.googlesource.com/c/exp/+/410855
Reviewed-by: Jonathan Amsterdam <[email protected]>

Author: jeanbza

apidiff/correspondence.go

@@ -126,6 +126,13 @@ func (d *differ) corr(old, new types.Type, p *ifacePair) bool {
 			return d.establishCorrespondence(old, new)
 		}
 
+	case *types.TypeParam:
+		if new, ok := new.(*types.TypeParam); ok {
+			if old.Index() == new.Index() {
+				return true
+			}
+		}
+
 	default:
 		panic(fmt.Sprintf("unknown type kind %T", old))
 	}

cmd/gorelease/testdata/generics/changed_param.test

@@ -0,0 +1,25 @@
+mod=example.com/generics
+base=v0.0.1
+-- want --
+# example.com/generics/a
+## incompatible changes
+Foo[V any].Value: changed from func() V to func() any
+## compatible changes
+Number: added
+
+# summary
+Suggested version: v0.1.0
+-- go.mod --
+module example.com/generics
+
+go 1.18
+-- a/a.go --
+package a
+
+type Number interface {
+    int64 | float64
+}
+
+type Foo[V Number] interface {
+    Value() any
+}

cmd/gorelease/testdata/generics/changed_return.test

@@ -0,0 +1,19 @@
+mod=example.com/generics
+base=v0.0.1
+-- want --
+# example.com/generics/a
+## incompatible changes
+Foo[V any].Value: changed from func() V to func() int
+
+# summary
+Suggested version: v0.1.0
+-- go.mod --
+module example.com/generics
+
+go 1.18
+-- a/a.go --
+package a
+
+type Foo[V any] interface {
+    Value() int
+}

cmd/gorelease/testdata/generics/unchanged.test

@@ -0,0 +1,15 @@
+mod=example.com/generics
+base=v0.0.1
+-- want --
+# summary
+Suggested version: v0.0.2
+-- go.mod --
+module example.com/generics
+
+go 1.18
+-- a/a.go --
+package a
+
+type Foo[V any] interface {
+    Value() V
+}

cmd/gorelease/testdata/mod/example.com_generics_v0.0.1.txt

@@ -0,0 +1,14 @@
+-- go.mod --
+module example.com/generics
+
+go 1.18
+-- a/a.go --
+package a
+
+type Urk[T any] interface {
+    Value() T
+}
+
+type Foo[V any] interface {
+    Value() V
+}