internal/buffer: add String method

Change-Id: Ic041a15e505df39476fada1079b31ef6d68c13b5
Reviewed-on: https://go-review.googlesource.com/c/exp/+/435380
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Alan Donovan <[email protected]>
Run-TryBot: Jonathan Amsterdam <[email protected]>

Author: jba

slog/handler.go

@@ -181,7 +181,7 @@ func (h *commonHandler) handle(r Record) error {
 				buf.WriteString(file)
 				buf.WriteByte(':')
 				itoa((*[]byte)(buf), line, -1)
-				s := string(*buf)
+				s := buf.String()
 				buf.Free()
 				replace(String(key, s))
 			}

slog/internal/buffer/buffer.go

@@ -44,3 +44,7 @@ func (b *Buffer) WriteString(s string) {
 func (b *Buffer) WriteByte(c byte) {
 	*b = append(*b, c)
 }
+
+func (b *Buffer) String() string {
+	return string(*b)
+}

slog/internal/buffer/buffer_test.go

@@ -12,7 +12,7 @@ func Test(t *testing.T) {
 	b.WriteString("hello")
 	b.WriteByte(',')
 	b.Write([]byte(" world"))
-	got := string(*b)
+	got := b.String()
 	want := "hello, world"
 	if got != want {
 		t.Errorf("got %q, want %q", got, want)

slog/record_test.go

@@ -132,7 +132,7 @@ func BenchmarkSourceLine(b *testing.B) {
 			buf.WriteString(file)
 			buf.WriteByte(':')
 			itoa((*[]byte)(buf), line, -1)
-			s := string(*buf)
+			s := buf.String()
 			buf.Free()
 			_ = s
 		}