Skip to content

Commit 0e4e2e6

Browse files
mknyszekgopherbot
authored andcommitted
runtime: skip TestGoroutineLeakProfile under mayMoreStackPreempt
This may be the long-term fix, but we first need to understand if this just makes the tests flaky, or if it's revealing an actual underlying issue. I'm leaning toward the former. If it is the former, ideally we just make the tests robust (wait longer, maybe?). For now, this change will make the longtest builders OK again. For #75729. Change-Id: If9b30107d04a8e5af5670850add3a53f9471eec6 Reviewed-on: https://go-review.googlesource.com/c/go/+/708715 Reviewed-by: Roland Shoemaker <[email protected]> Reviewed-by: Michael Pratt <[email protected]> Auto-Submit: Michael Knyszek <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Carlos Amedee <[email protected]>
1 parent f03c392 commit 0e4e2e6

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

src/runtime/goroutineleakprofile_test.go

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,20 @@ package runtime_test
66

77
import (
88
"fmt"
9+
"internal/testenv"
10+
"os"
911
"regexp"
1012
"strings"
1113
"testing"
1214
)
1315

1416
func TestGoroutineLeakProfile(t *testing.T) {
17+
if strings.Contains(os.Getenv("GOFLAGS"), "mayMoreStackPreempt") {
18+
// Some tests have false negatives under mayMoreStackPreempt. This may be a test-only issue,
19+
// but needs more investigation.
20+
testenv.SkipFlaky(t, 75729)
21+
}
22+
1523
// Goroutine leak test case.
1624
//
1725
// Test cases can be configured with test name, the name of the entry point function,
@@ -356,7 +364,7 @@ func TestGoroutineLeakProfile(t *testing.T) {
356364
`\(\*Page_hugo5379\)\.initContent\.func1\.1\(.* \[sync\.Mutex\.Lock\]`,
357365
`pageRenderer_hugo5379\(.* \[sync\.Mutex\.Lock\]`,
358366
`Hugo5379\.func2\(.* \[sync\.WaitGroup\.Wait\]`,
359-
),
367+
),
360368
makeFlakyTest("Istio16224",
361369
`Istio16224\.func2\(.* \[sync\.Mutex\.Lock\]`,
362370
`\(\*controller_istio16224\)\.Run\(.* \[chan send\]`,

0 commit comments

Comments
 (0)