Skip to content

Commit 6fbad4b

Browse files
randall77gopherbot
authored andcommitted
cmd/compile: remove no-longer-necessary call to calculateDepths
We now calculate depths by default, no need to ask. All calls were removed in CL 680775 when that CL was written, but an additional call appeared between then and submitting the CL. Oops. Another case for which a presubmit check would help. Fixes #74762 Change-Id: I1b70ed7f91b56e4939b4a3d0ad7a5f31fe396b4c Reviewed-on: https://go-review.googlesource.com/c/go/+/690036 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Keith Randall <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> Reviewed-by: t hepudds <[email protected]>
1 parent 5045fdd commit 6fbad4b

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

src/cmd/compile/internal/ssa/likelyadjust.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ type loop struct {
1515
// Next three fields used by regalloc and/or
1616
// aid in computation of inner-ness and list of blocks.
1717
nBlocks int32 // Number of blocks in this loop but not within inner loops
18-
depth int16 // Nesting depth of the loop; 1 is outermost. Initialized by calculateDepths().
18+
depth int16 // Nesting depth of the loop; 1 is outermost.
1919
isInner bool // True if never discovered to contain a loop
2020

2121
// True if all paths through the loop have a call.

src/cmd/compile/internal/ssa/looprotate.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ func loopRotate(f *Func) {
8282

8383
// Order loops to rotate any child loop before adding its top block
8484
// to the parent loop's 'after' list.
85-
loopnest.calculateDepths()
8685
loopOrder := f.Cache.allocIntSlice(len(loopnest.loops))
8786
for i := range loopOrder {
8887
loopOrder[i] = i

0 commit comments

Comments
 (0)