Skip to content

Commit 8282b72

Browse files
committed
runtime/race: update darwin race syso
On macOS, the script in LLVM TSAN building the race syso files produces the Mach-O object with a malformed dynamic symbol table, which new Apple linker doesn't like and emits an annoying warning (#61229 (comment)). The dynamic symbol table isn't really needed, as it is a static object. Perhaps it should be fixed in TSAN or the C toolchain, but we can do a simple workaround: pass it through "ld -r", which produces an equivalent object file with LC_DYSYMTAB removed. CL 692975 changes racebuild to do this, which produces new syso's in this CL. While here, build the syso with a newer version of LLVM TSAN. Updates #61229. Change-Id: Ide4b7831eb2cb6877c8ace7b3ec8ff565a9eaf54 Reviewed-on: https://go-review.googlesource.com/c/go/+/692996 Reviewed-by: David Chase <[email protected]> TryBot-Bypass: Cherry Mui <[email protected]>
1 parent dc54d7b commit 8282b72

File tree

5 files changed

+4
-16
lines changed

5 files changed

+4
-16
lines changed

src/runtime/race/README

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@ the LLVM project (https://github.com/llvm/llvm-project/tree/main/compiler-rt).
44

55
To update the .syso files use golang.org/x/build/cmd/racebuild.
66

7-
internal/amd64v1/race_darwin.syso built with LLVM 51bfeff0e4b0757ff773da6882f4d538996c9b04 and Go e7d582b55dda36e76ce4d0ce770139ca0915b7c5.
7+
internal/amd64v1/race_darwin.syso built with LLVM 0398ad41bdf1ce5f74c80a74494bfe733fe3e214 and Go b2960e35804aafbbb0df9973f99b034bea8c150a.
88
internal/amd64v1/race_freebsd.syso built with LLVM 51bfeff0e4b0757ff773da6882f4d538996c9b04 and Go e7d582b55dda36e76ce4d0ce770139ca0915b7c5.
99
internal/amd64v1/race_linux.syso built with LLVM 51bfeff0e4b0757ff773da6882f4d538996c9b04 and Go e7d582b55dda36e76ce4d0ce770139ca0915b7c5.
1010
internal/amd64v1/race_netbsd.syso built with LLVM 51bfeff0e4b0757ff773da6882f4d538996c9b04 and Go e7d582b55dda36e76ce4d0ce770139ca0915b7c5.
1111
internal/amd64v1/race_openbsd.syso built with LLVM fcf6ae2f070eba73074b6ec8d8281e54d29dbeeb and Go 8f2db14cd35bbd674cb2988a508306de6655e425.
1212
internal/amd64v1/race_windows.syso built with LLVM 51bfeff0e4b0757ff773da6882f4d538996c9b04 and Go e7d582b55dda36e76ce4d0ce770139ca0915b7c5.
1313
internal/amd64v3/race_linux.syso built with LLVM 51bfeff0e4b0757ff773da6882f4d538996c9b04 and Go e7d582b55dda36e76ce4d0ce770139ca0915b7c5.
14-
race_darwin_arm64.syso built with LLVM 51bfeff0e4b0757ff773da6882f4d538996c9b04 and Go e7d582b55dda36e76ce4d0ce770139ca0915b7c5.
14+
race_darwin_arm64.syso built with LLVM 0398ad41bdf1ce5f74c80a74494bfe733fe3e214 and Go b2960e35804aafbbb0df9973f99b034bea8c150a.
1515
race_linux_arm64.syso built with LLVM 51bfeff0e4b0757ff773da6882f4d538996c9b04 and Go e7d582b55dda36e76ce4d0ce770139ca0915b7c5.
1616
race_linux_loong64.syso built with LLVM 83fe85115da9dc25fa270d2ea8140113c8d49670 and Go 037112464b4439571b45536de9ebe4bc9e10ecb7.
1717
race_linux_ppc64le.syso built with LLVM 51bfeff0e4b0757ff773da6882f4d538996c9b04 and Go e7d582b55dda36e76ce4d0ce770139ca0915b7c5.
Binary file not shown.

src/runtime/race/race_darwin_amd64.go

Lines changed: 1 addition & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/runtime/race/race_darwin_arm64.go

Lines changed: 1 addition & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
12.5 KB
Binary file not shown.

0 commit comments

Comments
 (0)