Skip to content

Commit 9d1e738

Browse files
committed
playground: fix the build for gVisor
Exec permissions need to be granted on /tmpfs on Docker in order for binaries downloaded there to be executable. Additionally, newer versions of gVisor only create the __runsc_containers__ file in a multi-container environment, which is not the case for testing. Updates golang/go#25224 Change-Id: I272535558d952e423f75ba9770a491472e9c8eff Reviewed-on: https://go-review.googlesource.com/c/playground/+/227349 Reviewed-by: Carlos Amedee <[email protected]>
1 parent dda036d commit 9d1e738

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

sandbox/sandbox.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,7 @@ func startContainer(ctx context.Context) (c *Container, err error) {
358358
cmd := exec.Command("docker", "run",
359359
"--name="+name,
360360
"--rm",
361-
"--tmpfs=/tmpfs",
361+
"--tmpfs=/tmpfs:exec",
362362
"-i", // read stdin
363363

364364
"--runtime=runsc",

tests.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,6 @@ func main() {
264264
}
265265
for _, expect := range []string{
266266
"/.dockerenv",
267-
"/__runsc_containers__",
268267
"/etc/hostname",
269268
"/dev/zero",
270269
"/lib/ld-linux-x86-64.so.2",

0 commit comments

Comments
 (0)