Skip to content

Commit 0382e76

Browse files
committed
protoc-gen-go: include groups in public import forwarders
Groups were being excluded from the set of messages we generate forwarding declarations for. Include them.
1 parent d18af0d commit 0382e76

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

protoc-gen-go/generator/generator.go

Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2707,26 +2707,23 @@ func (g *Generator) generateMessage(message *Descriptor) {
27072707
g.generateOneofFuncs(mc, topLevelFields)
27082708
g.P()
27092709

2710-
if !message.group {
2711-
2712-
var oneofTypes []string
2713-
for _, f := range topLevelFields {
2714-
if of, ok := f.(*oneofField); ok {
2715-
for _, osf := range of.subFields {
2716-
oneofTypes = append(oneofTypes, osf.oneofTypeName)
2717-
}
2710+
var oneofTypes []string
2711+
for _, f := range topLevelFields {
2712+
if of, ok := f.(*oneofField); ok {
2713+
for _, osf := range of.subFields {
2714+
oneofTypes = append(oneofTypes, osf.oneofTypeName)
27182715
}
27192716
}
2717+
}
27202718

2721-
opts := message.Options
2722-
ms := &messageSymbol{
2723-
sym: goTypeName,
2724-
hasExtensions: len(message.ExtensionRange) > 0,
2725-
isMessageSet: opts != nil && opts.GetMessageSetWireFormat(),
2726-
oneofTypes: oneofTypes,
2727-
}
2728-
g.file.addExport(message, ms)
2719+
opts := message.Options
2720+
ms := &messageSymbol{
2721+
sym: goTypeName,
2722+
hasExtensions: len(message.ExtensionRange) > 0,
2723+
isMessageSet: opts != nil && opts.GetMessageSetWireFormat(),
2724+
oneofTypes: oneofTypes,
27292725
}
2726+
g.file.addExport(message, ms)
27302727

27312728
for _, ext := range message.ext {
27322729
g.generateExtension(ext)

protoc-gen-go/testdata/import_public/a.pb.go

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)