Skip to content

Commit 1680a47

Browse files
menghanldsnet
authored andcommitted
protoc-gen-go: fix deprecated comment for grpc methods (#952)
1 parent 822fe56 commit 1680a47

File tree

2 files changed

+12
-0
lines changed

2 files changed

+12
-0
lines changed

protoc-gen-go/grpc/grpc.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,10 @@ func (g *grpc) generateService(file *generator.FileDescriptor, service *pb.Servi
166166
g.P("type ", servName, "Client interface {")
167167
for i, method := range service.Method {
168168
g.gen.PrintComments(fmt.Sprintf("%s,2,%d", path, i)) // 2 means method in a service.
169+
if method.GetOptions().GetDeprecated() {
170+
g.P("//")
171+
g.P(deprecationComment)
172+
}
169173
g.P(g.generateClientSignature(servName, method))
170174
}
171175
g.P("}")
@@ -213,6 +217,10 @@ func (g *grpc) generateService(file *generator.FileDescriptor, service *pb.Servi
213217
g.P("type ", serverType, " interface {")
214218
for i, method := range service.Method {
215219
g.gen.PrintComments(fmt.Sprintf("%s,2,%d", path, i)) // 2 means method in a service.
220+
if method.GetOptions().GetDeprecated() {
221+
g.P("//")
222+
g.P(deprecationComment)
223+
}
216224
g.P(g.generateServerSignature(servName, method))
217225
}
218226
g.P("}")

protoc-gen-go/testdata/deprecated/deprecated.pb.go

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)