internal/lsp: replace mistaken "break" with "continue"

I had meant to continue instead of break this loop. This caused us to
invalidate all IDs (except for those for one file) every time a snapshot
was cloned.

Picked up a staticcheck fix along the way.

Change-Id: I8fb3b2bdd6b58ac21130e01cb0d32fa6a57e6b73
Reviewed-on: https://go-review.googlesource.com/c/tools/+/221103
Run-TryBot: Rebecca Stambler <[email protected]>
Reviewed-by: Rohan Challa <[email protected]>

Author: stamblerre

internal/lsp/cache/snapshot.go

@@ -131,7 +131,7 @@ func (s *snapshot) buildOverlay() map[string][]byte {
 
 func (s *snapshot) PackageHandles(ctx context.Context, fh source.FileHandle) ([]source.PackageHandle, error) {
 	if fh.Identity().Kind != source.Go {
-		panic(fmt.Sprintf("called PackageHandles on a non-Go FileHandle"))
+		panic("called PackageHandles on a non-Go FileHandle")
 	}
 
 	ctx = telemetry.File.With(ctx, fh.Identity().URI)
@@ -743,7 +743,7 @@ outer:
 	for k, ids := range s.ids {
 		for _, id := range ids {
 			if invalidateMetadata, ok := transitiveIDs[id]; invalidateMetadata && ok {
-				break outer
+				continue outer
 			}
 		}
 		result.ids[k] = ids