all: merge master (7f10777) into gopls-release-branch.0.8

Also update gopls/go.mod to replace x/tools.

For golang/go#52213

Conflicts:

- gopls/go.mod
- gopls/go.sum

Merge List:

+ 2022-04-07 7f10777 gopls/internal/regtest/modfile: temporarily skip TestSumUpdateFixesDiagnostics
+ 2022-04-07 7cc24c2 gopls: upgrade staticcheck to v0.3.0
+ 2022-04-07 1f763df internal/lsp: add semantic tokens for arrows in declarations
+ 2022-04-06 b3e0236 go/ssa: Track created functions in the builder.
+ 2022-04-06 6731659 go/ssa: adds position info to implicit field selection instructions
+ 2022-04-06 74cea6e internal/imports: ignore some line directives
+ 2022-04-05 37acb39 internal/lsp: run vulncheck in specified dir
+ 2022-04-04 4077921 all: fix spelling
+ 2022-04-04 ff66cbe internal/lsp: remove unused parameters from moduleAtVersion
+ 2022-04-04 7d125fe cmd/callgraph: expand windows/arm64 skip to the whole platform
+ 2022-04-01 153e30b internal/lsp/lsprpc: only propagate explicit GOWORK when using remote
+ 2022-03-31 cda13e2 internal/lsp: fix incorrect line and start of semantic tokens
+ 2022-03-31 41787c4 gopls: run go mod tidy -compat=1.16 to fix the 1.16 build
+ 2022-03-31 b9a4807 internal/gopathwalk: remove unnecessary call to os.Lstat
+ 2022-03-30 8e193c2 go/ssa: removes conversion of index value in Index and IndexAddr to int
+ 2022-03-30 9d8009b go/analysis: validate report if analyzer.Run is empty
+ 2022-03-29 761e51f go/ssa/interp: Adds reflect.DeepEqual model for interp testing

Change-Id: I2d9255f835fada04e125aa3bb16571a02a50d6d7

Author: findleyr

cmd/callgraph/main_test.go

@@ -15,6 +15,7 @@ import (
 	"log"
 	"os"
 	"path/filepath"
+	"runtime"
 	"strings"
 	"testing"
 
@@ -34,8 +35,8 @@ func init() {
 }
 
 func TestCallgraph(t *testing.T) {
-	if b := os.Getenv("GO_BUILDER_NAME"); b == "windows-arm64-10" {
-		t.Skipf("skipping due to suspected file corruption bug on %s builder (https://go.dev/issue/50706)", b)
+	if runtime.GOOS == "windows" && runtime.GOARCH == "arm64" {
+		t.Skipf("skipping due to suspected file corruption bug on windows/arm64 (https://go.dev/issue/50706)")
 	}
 
 	testenv.NeedsTool(t, "go")

cmd/splitdwarf/splitdwarf.go

@@ -94,7 +94,7 @@ for input_exe need to allow writing.
 	//   IndSym Offset = file offset (within link edit section) of 4-byte indices within symtab.
 	//
 	// Section __TEXT.__symbol_stub1.
-	//   Offset and size (Reserved2) locate and describe a table for thios section.
+	//   Offset and size (Reserved2) locate and describe a table for this section.
 	//   Symbols beginning at IndirectSymIndex (Reserved1) (see LC_DYSYMTAB.IndSymOffset) refer to this table.
 	//   (These table entries are apparently PLTs [Procedure Linkage Table/Trampoline])
 	//

go/analysis/internal/checker/checker.go

@@ -826,7 +826,7 @@ func codeFact(fact analysis.Fact) (analysis.Fact, error) {
 
 // exportedFrom reports whether obj may be visible to a package that imports pkg.
 // This includes not just the exported members of pkg, but also unexported
-// constants, types, fields, and methods, perhaps belonging to oether packages,
+// constants, types, fields, and methods, perhaps belonging to other packages,
 // that find there way into the API.
 // This is an overapproximation of the more accurate approach used by
 // gc export data, which walks the type graph, but it's much simpler.

go/analysis/passes/nilness/testdata/src/a/a.go

@@ -181,3 +181,16 @@ func f11(a interface{}) {
 		return
 	}
 }
+
+type Y struct {
+	innerY
+}
+
+type innerY struct {
+	value int
+}
+
+func f12() {
+	var d *Y
+	print(d.value) // want "nil dereference in field selection"
+}

go/analysis/passes/sigchanyzer/sigchanyzer.go

@@ -50,7 +50,7 @@ func run(pass *analysis.Pass) (interface{}, error) {
 			}
 		case *ast.CallExpr:
 			// Only signal.Notify(make(chan os.Signal), os.Interrupt) is safe,
-			// conservatively treate others as not safe, see golang/go#45043
+			// conservatively treat others as not safe, see golang/go#45043
 			if isBuiltinMake(pass.TypesInfo, arg) {
 				return
 			}

go/analysis/validate.go

@@ -14,6 +14,8 @@ import (
 // Validate reports an error if any of the analyzers are misconfigured.
 // Checks include:
 // that the name is a valid identifier;
+// that the Doc is not empty;
+// that the Run is non-nil;
 // that the Requires graph is acyclic;
 // that analyzer fact types are unique;
 // that each fact type is a pointer.
@@ -46,6 +48,9 @@ func Validate(analyzers []*Analyzer) error {
 				return fmt.Errorf("analyzer %q is undocumented", a)
 			}
 
+			if a.Run == nil {
+				return fmt.Errorf("analyzer %q has nil Run", a)
+			}
 			// fact types
 			for _, f := range a.FactTypes {
 				if f == nil {

go/analysis/validate_test.go

@@ -11,33 +11,43 @@ import (
 
 func TestValidate(t *testing.T) {
 	var (
+		run = func(p *Pass) (interface{}, error) {
+			return nil, nil
+		}
 		dependsOnSelf = &Analyzer{
 			Name: "dependsOnSelf",
 			Doc:  "this analyzer depends on itself",
+			Run:  run,
 		}
 		inCycleA = &Analyzer{
 			Name: "inCycleA",
 			Doc:  "this analyzer depends on inCycleB",
+			Run:  run,
 		}
 		inCycleB = &Analyzer{
 			Name: "inCycleB",
 			Doc:  "this analyzer depends on inCycleA and notInCycleA",
+			Run:  run,
 		}
 		pointsToCycle = &Analyzer{
 			Name: "pointsToCycle",
 			Doc:  "this analyzer depends on inCycleA",
+			Run:  run,
 		}
 		notInCycleA = &Analyzer{
 			Name: "notInCycleA",
 			Doc:  "this analyzer depends on notInCycleB and notInCycleC",
+			Run:  run,
 		}
 		notInCycleB = &Analyzer{
 			Name: "notInCycleB",
 			Doc:  "this analyzer depends on notInCycleC",
+			Run:  run,
 		}
 		notInCycleC = &Analyzer{
 			Name: "notInCycleC",
 			Doc:  "this analyzer has no dependencies",
+			Run:  run,
 		}
 	)
 
@@ -116,3 +126,27 @@ func TestCycleInRequiresGraphErrorMessage(t *testing.T) {
 		t.Errorf("error string %s does not contain expected substring %q", errMsg, wantSubstring)
 	}
 }
+
+func TestValidateEmptyDoc(t *testing.T) {
+	withoutDoc := &Analyzer{
+		Name: "withoutDoc",
+		Run: func(p *Pass) (interface{}, error) {
+			return nil, nil
+		},
+	}
+	err := Validate([]*Analyzer{withoutDoc})
+	if err == nil || !strings.Contains(err.Error(), "is undocumented") {
+		t.Errorf("got unexpected error while validating analyzers withoutDoc: %v", err)
+	}
+}
+
+func TestValidateNoRun(t *testing.T) {
+	withoutRun := &Analyzer{
+		Name: "withoutRun",
+		Doc:  "this analyzer has no Run",
+	}
+	err := Validate([]*Analyzer{withoutRun})
+	if err == nil || !strings.Contains(err.Error(), "has nil Run") {
+		t.Errorf("got unexpected error while validating analyzers withoutRun: %v", err)
+	}
+}

go/pointer/analysis.go

@@ -59,8 +59,8 @@ type object struct {
 	//
 	// ssa.Value	for an object allocated by an SSA operation.
 	// types.Type	for an rtype instance object or *rtype-tagged object.
-	// string	for an instrinsic object, e.g. the array behind os.Args.
-	// nil		for an object allocated by an instrinsic.
+	// string	for an intrinsic object, e.g. the array behind os.Args.
+	// nil		for an object allocated by an intrinsic.
 	//		(cgn provides the identity of the intrinsic.)
 	data interface{}