Skip to content

Commit 0dca43f

Browse files
committed
internal/lsp/source: disable fillstruct by default
The discussion on golang/vscode-go#299 has uncovered the fact that go/printer is very expensive, and we're calling it frequently on file changes. Analyzers whose suggested fixes require the original file content are generally posing issues; this is being discussed on golang/go#40110. Updates golang/vscode-go#299 Change-Id: I5cb370c9cb508203e463e7243fc781e75876fe30 Reviewed-on: https://go-review.googlesource.com/c/tools/+/241321 Run-TryBot: Rebecca Stambler <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Heschi Kreinick <[email protected]> (cherry picked from commit d5a7453) Reviewed-on: https://go-review.googlesource.com/c/tools/+/241322
1 parent 8923253 commit 0dca43f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

internal/lsp/source/options.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -632,7 +632,7 @@ func convenienceAnalyzers() map[string]Analyzer {
632632
return map[string]Analyzer{
633633
fillstruct.Analyzer.Name: {
634634
Analyzer: fillstruct.Analyzer,
635-
enabled: true,
635+
enabled: false,
636636
},
637637
}
638638
}

0 commit comments

Comments
 (0)