internal/lsp: fix time.Duration hover name check

stamblerre · stamblerre · commit 1523bb47d8d7 · 2021-03-09T20:20:25.000Z
Change-Id: I30a0e9848e5578b66628e055f6125d2a352dc6d5 Reviewed-on: https://go-review.googlesource.com/c/tools/+/300189 Trust: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
diff --git a/internal/lsp/source/hover.go b/internal/lsp/source/hover.go
@@ -241,7 +241,7 @@ func objectString(obj types.Object, qf types.Qualifier) string {
 			break
 		}
 		pkg := typ.Obj().Pkg()
-		if pkg.Path() == "time" && pkg.Scope().Lookup("Duration") != nil {
+		if pkg.Path() == "time" && typ.Obj().Name() == "Duration" {
 			if d, ok := constant.Int64Val(obj.Val()); ok {
 				str += " // " + time.Duration(d).String()
 			}

Original file line number	Diff line number	Diff line change
`@@ -241,7 +241,7 @@ func objectString(obj types.Object, qf types.Qualifier) string {`
`241`	`241`	`break`
`242`	`242`	`}`
`243`	`243`	`pkg := typ.Obj().Pkg()`
`244`		`- if pkg.Path() == "time" && pkg.Scope().Lookup("Duration") != nil {`
	`244`	`+ if pkg.Path() == "time" && typ.Obj().Name() == "Duration" {`
`245`	`245`	`if d, ok := constant.Int64Val(obj.Val()); ok {`
`246`	`246`	`str += " // " + time.Duration(d).String()`
`247`	`247`	`}`