[gopls-release-branch.0.7] all: merge master into gopls-release-branch.0.7

4fe0d6c internal/lsp: skip signature help within a string literal
0c506a2 internal/lsp/source: evaluate bin/hex literal on hover
46d1522 internal/lsp: add extract to method code action
c740bfd internal/lsp: handle incorrect import with CRLF line endings
251092d internal/lsp/source: compute imports text edits from scratch
412ee17 all: add SliceToArrayPointer instruction
7f68387 internal/lsp/source: workspace symbol improvements for selectors
7aa8294 internal/lsp: handle panic in fix AST
6e9046b gopls/doc: fix imports function for Neovim LSP
0cf4e27 internal/lsp/semantic: improve semantic token processing
5061c41 internal/lsp: signal diagnostic completion if modification failed
ef97713 gopls/doc: add vetted examples for Sublime Text
8e85a28 internal/lsp: adopt bcmills' suggestion for an improved debouncer API
ae0deb7 internal/lsp: fix variable reuse bug in code actions
d36a54b internal/lsp: improve package search in a couple places
3844600 gopls/internal/regtest: add a flag to profile didChange handling
de44776 gopls/doc: Neovim v0.5 is now stable
ccff732 internal/lsp/source: fix comment update during rename for short variable declarations
a7dfe3d internal/lsp: attempt to make TestDebouncer more robust
980829d internal/lsp/lsprpc: add an AutoDialer abstraction
cb1acef Revert "internal/lsp/semantic.go: repress useless messages and tighten logic"
5b540d3 internal/lsp/semantic.go: repress useless messages and tighten logic
e33c0f2 go/packages: skip tests that link binaries in short mode
8e32e9f internal/lsp/regtest: fix a panic TestResolveImportCycle
2583041 go/packages: fix data race in TestCgoNoSyntax
6994825 go/ssa: incorrect document in type Builtin struct
e688b94 go/packages: parallelize most tests
64bd808 internal/lsp/cache: don't report a context error if load succeeded
cae92d5 go/packages: skip GOPATH tests in short mode
2f04284 internal/lsp/regtest: allow for unsent diagnostics in TestResolveImportCycle
41a65bd internal/lsp: avoid flake in TestDebouncer
1c9019e internal/lsp/cache: fix raciness of updating the view workspace
febfa9d internal/lsp/source: move diagnosticsDelay out of experimental
71eae3a internal/lsp/cache: be consistent about using snapshot.FileSet
251f283 internal/lsp: add a setting to batch didChangeWatchedFile notifications
c979f92 internal/lsp/cache: invalidate packages in setMetadata
55cd480 gopls/doc: Document how gopls generates semantic tokens.
77c1b7a internal/lsp/cmd: print flags when running gopls help
640c1de go/ssa: support unsafe.Add and unsafe.Slice
fd00574 internal/lsp/protocol: upgrade generated lsp code to beginning of July
7edcfe5 internal/lsp/lsprpc: add a goenv middleware
e3040f2 internal/lsp/lsprpc: add a CommandInterceptor middleware
ea37029 internal/lsp/lsprpc: use middleware for the V2 handshaking
20dafe5 go/ssa: allow conversion from slice to array pointer
f0847e0 go/callgraph: change reflect.Call to reflect.Value.Call in comment
72e4d1b go/internal/cgo: handle symlinks with $PWD, not -srcdir
100b229 internal/lsp/cache: treat load timeouts as critical errors
12f8456 internal/testenv: actually Exit if small machine for netbsd-arm*-bsiegert
00129ff internal/lsp/lsprpc: update binder tests to handle forwarding
fe2294a internal/jsonrpc2_v2: initialize async before binding
636017e internal/lsp/cache: fix missing pkg error on Windows
48cad5e tools/gopls: small fixes to contributing.md
da404b5 internal/lsp: start parsing go.work file like gopls.mod file
4833ac5 internal/mod: add workfile parser
bfc1674 internal/lsp/cache: fix loading of std and cmd
d824a74 gopls/doc: include instructions for compiling generic code
6d3e439 gopls/doc: add instructions for working with generic code
4c651fc internal/lsp/source: add inferred types to generic function hover
d25f906  internal/lsp: do not block on channel when there is an error
463a76b internal/lsp: only reload invalid metadata when necessary
116feae internal/lsp: move the progress tracker to the session
3f7c326 gopls/internal/regtest: skip the flaky TestResolveImportCycle
b12e617 internal/lsp/cache: don't delete metadata until it's reloaded
4b484fb internal/lsp: exclude the module cache from the workspace
9a55cb1 internal/lsp/command: minor clean-up of StartDebugging description
490eac8 internal/lsp/command: add missing doc and support for result parameters
9aa007e internal/lsp/cache: invalidate broken packages when imports are deleted
f6327c5 vta: adds the VTA call graph construction
13cf844 go/ast/astutil: fix panic when rewriting multi-argument type instances
937957b vta: adds VTA graph propagation functionality
e0b9cf7 lsp/completion: support completing to Elem() types
16e5f55 lsp/completion: search deeper for candidate type mods
b579874 lsp/completion: reorganize how we track candidate type mods
890984b internal/lsp: change generated variable names to be more verbose
9f230b5 internal/lsp: fix extract bug choosing available identifiers
4e58f8f internal/lsp: handle out of range panic in template parsing
716319f vta: finalizes VTA graph construction by adding support for function calls
234f954 vta: extends VTA graph construction to handle collections
126df1d cmd/getgo: determine current version via /dl/?mode=json API
b9b845e internal/lsp: fix folding range for block comments
1225b6f internal/lsp: memoize allKnownSubdirs instead of recomputing
7295a4e lsp/completion: don't offer untyped conversions
bf13205 vta: adds VTA graph construction for basic program statements
8f2cf6c gopls/internal/regtest: clean up TestFillReturnsPanic
4abb1e2 internal/lsp: handle empty buffers in template parsing
7ac129f internal/lsp: don't diagnose/analyze intermediate test variants
1c2154a internal/lsp: address some staticcheck warning

Change-Id: Ie2238b8bad61a238b46d1e5ae34e0c5fd13950be

Author: stamblerre

cmd/getgo/download.go

@@ -12,6 +12,7 @@ import (
 	"archive/zip"
 	"compress/gzip"
 	"crypto/sha256"
+	"encoding/json"
 	"fmt"
 	"io"
 	"io/ioutil"
@@ -22,7 +23,6 @@ import (
 )
 
 const (
-	currentVersionURL = "https://golang.org/VERSION?m=text"
 	downloadURLPrefix = "https://dl.google.com/go"
 )
 
@@ -168,18 +168,24 @@ func unpackZip(src, dest string) error {
 }
 
 func getLatestGoVersion() (string, error) {
-	resp, err := http.Get(currentVersionURL)
+	resp, err := http.Get("https://golang.org/dl/?mode=json")
 	if err != nil {
 		return "", fmt.Errorf("Getting current Go version failed: %v", err)
 	}
 	defer resp.Body.Close()
-	if resp.StatusCode > 299 {
+	if resp.StatusCode != http.StatusOK {
 		b, _ := ioutil.ReadAll(io.LimitReader(resp.Body, 1024))
-		return "", fmt.Errorf("Could not get current Go version: HTTP %d: %q", resp.StatusCode, b)
+		return "", fmt.Errorf("Could not get current Go release: HTTP %d: %q", resp.StatusCode, b)
+	}
+	var releases []struct {
+		Version string
 	}
-	version, err := ioutil.ReadAll(resp.Body)
+	err = json.NewDecoder(resp.Body).Decode(&releases)
 	if err != nil {
 		return "", err
 	}
-	return strings.TrimSpace(string(version)), nil
+	if len(releases) < 1 {
+		return "", fmt.Errorf("Could not get at least one Go release")
+	}
+	return releases[0].Version, nil
 }

go/ast/astutil/rewrite.go

@@ -9,6 +9,8 @@ import (
 	"go/ast"
 	"reflect"
 	"sort"
+
+	"golang.org/x/tools/internal/typeparams"
 )
 
 // An ApplyFunc is invoked by Apply for each node n, even if n is nil,
@@ -437,7 +439,11 @@ func (a *application) apply(parent ast.Node, name string, iter *iterator, n ast.
 		}
 
 	default:
-		panic(fmt.Sprintf("Apply: unexpected node type %T", n))
+		if typeparams.IsListExpr(n) {
+			a.applyList(n, "ElemList")
+		} else {
+			panic(fmt.Sprintf("Apply: unexpected node type %T", n))
+		}
 	}
 
 	if a.post != nil && !a.post(&a.cursor) {

go/ast/astutil/rewrite_test.go

@@ -13,13 +13,16 @@ import (
 	"testing"
 
 	"golang.org/x/tools/go/ast/astutil"
+	"golang.org/x/tools/internal/typeparams"
 )
 
-var rewriteTests = [...]struct {
+type rewriteTest struct {
 	name       string
 	orig, want string
 	pre, post  astutil.ApplyFunc
-}{
+}
+
+var rewriteTests = []rewriteTest{
 	{name: "nop", orig: "package p\n", want: "package p\n"},
 
 	{name: "replace",
@@ -190,6 +193,34 @@ var z int
 	},
 }
 
+func init() {
+	if typeparams.Enabled {
+		rewriteTests = append(rewriteTests, rewriteTest{
+			name: "replace",
+			orig: `package p
+
+type T[P1, P2 any] int
+
+type R T[int, string]
+`,
+			want: `package p
+
+type T[P1, P2 any] int32
+
+type R T[int32, string]
+`,
+			post: func(c *astutil.Cursor) bool {
+				if ident, ok := c.Node().(*ast.Ident); ok {
+					if ident.Name == "int" {
+						c.Replace(ast.NewIdent("int32"))
+					}
+				}
+				return true
+			},
+		})
+	}
+}
+
 func valspec(name, typ string) *ast.ValueSpec {
 	return &ast.ValueSpec{Names: []*ast.Ident{ast.NewIdent(name)},
 		Type: ast.NewIdent(typ),

go/callgraph/callgraph.go

@@ -89,7 +89,7 @@ func (n *Node) String() string {
 // A Edge represents an edge in the call graph.
 //
 // Site is nil for edges originating in synthetic or intrinsic
-// functions, e.g. reflect.Call or the root of the call graph.
+// functions, e.g. reflect.Value.Call or the root of the call graph.
 type Edge struct {
 	Caller *Node
 	Site   ssa.CallInstruction