Skip to content

Commit 3590a17

Browse files
committed
internal/mcp: fix prompt example
The hello example was using params.Name, which is the name of the prompt. It should use args.Name. Change-Id: I0e7e992bbe312fd5a6e56e9bc46a931f0eeb423c Reviewed-on: https://go-review.googlesource.com/c/tools/+/682416 Reviewed-by: Robert Findley <[email protected]> Reviewed-by: Sam Thanawalla <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
1 parent a71de77 commit 3590a17

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

internal/mcp/examples/hello/main.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,11 @@ func SayHi(ctx context.Context, ss *mcp.ServerSession, params *mcp.CallToolParam
3232

3333
// TODO(jba): it should be OK for args to be a pointer, but this fails in
3434
// jsonschema. Needs investigation.
35-
func PromptHi(ctx context.Context, ss *mcp.ServerSession, args HiArgs, params *mcp.GetPromptParams) (*mcp.GetPromptResult, error) {
35+
func PromptHi(ctx context.Context, ss *mcp.ServerSession, args HiArgs, _ *mcp.GetPromptParams) (*mcp.GetPromptResult, error) {
3636
return &mcp.GetPromptResult{
3737
Description: "Code review prompt",
3838
Messages: []*mcp.PromptMessage{
39-
{Role: "user", Content: mcp.NewTextContent("Say hi to " + params.Name)},
39+
{Role: "user", Content: mcp.NewTextContent("Say hi to " + args.Name)},
4040
},
4141
}, nil
4242
}

internal/mcp/prompt.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,11 +75,11 @@ func NewServerPrompt[In any](name, description string, handler func(context.Cont
7575
if err != nil {
7676
return nil, err
7777
}
78-
var v In
79-
if err := unmarshalSchema(rawArgs, resolved, &v); err != nil {
78+
var args In
79+
if err := unmarshalSchema(rawArgs, resolved, &args); err != nil {
8080
return nil, err
8181
}
82-
return handler(ctx, ss, v, params)
82+
return handler(ctx, ss, args, params)
8383
}
8484
for _, opt := range opts {
8585
opt.set(prompt)

0 commit comments

Comments
 (0)