Skip to content

Commit 52b9c68

Browse files
adonovangopherbot
authored andcommitted
go/ast/inspector: remove obsolete unsafe import
It should have been removed when we deleted the use of linkname. Also, add a postscript to a comment. Sadly I can't find the data. Change-Id: I05518a770b941a4f361f6ce7b80fc1b5bc94eab9 Reviewed-on: https://go-review.googlesource.com/c/tools/+/694056 Reviewed-by: Robert Findley <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Alan Donovan <[email protected]>
1 parent b155480 commit 52b9c68

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

go/ast/inspector/inspector.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ type event struct {
8585

8686
// TODO: Experiment with storing only the second word of event.node (unsafe.Pointer).
8787
// Type can be recovered from the sole bit in typ.
88+
// [Tried this, wasn't faster. --adonovan]
8889

8990
// Preorder visits all the nodes of the files supplied to New in
9091
// depth-first order. It calls f(n) for each node n before it visits

go/ast/inspector/typeof.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ package inspector
1212
import (
1313
"go/ast"
1414
"math"
15-
16-
_ "unsafe"
1715
)
1816

1917
const (

0 commit comments

Comments
 (0)