[gopls-release-branch.0.6] all: merge master into gopls-release-branch.0.6

0e232fa gopls: add scheme to CodeDescription.href
2363391 all: go fmt ./...
b369640 all: fmt tests with new gofmt
f6e0443 go/analysis: add unusedwrite pass
bdaa8bf go/gcexportdata: warn that {Read,Write}Bundle are experimental
f4301d9 internal/imports: update stdlib index for 1.16
f3748ed internal/lsp/source: filter out comparable from completion results
f47cb78 go/analysis/passes/buildtag: update check for //go:build
06713c2 go/loader: fix race
1f00549 internal/regtest: fix regtests for the dev.typeparams Go branch
4b19790 txtar: minor fix in unit test input
9eb3535 internal/lsp: 'go get' packages instead of modules
67e49ef go/internal/cgo: set pkgdir with -srcdir instead of CWD
19ff21f go/analysis/unitchecker: tell the user how to list the flags and analyzers
d5b8332 internal/lsp/command: rename package generate to gen
4534fc3 go/internal/gcimporter: reference golang/go#44339 in TODO
35839b7 go/internal/gcimporter: fix tests on darwin
a1db63c go/internal/gcimporter: add "bundled" export data formats
b79f76f go/internal/gcimporter: fix reexporting compiler data
7fde01f go/internal/gcimporter: refactor IExportData tests
6055ccf go/internal/gcimporter: simplify IExportData API
1e7abac internal/lsp: refactor go command error handling
ffc2075 internal/lsp: fix nil pointer in hover when (types.Object).Pkg() is nil
fca8992 internal/lsp: handle nil pointer with import shortcut = link
5848b84 internal/typesinternal: sync error codes with go1.16
3a5a051 go/analysis/passes: add sigchanyzer Analyzer

Change-Id: I1d4a41669e2f8e8115fb5d62cc25a62f7c755ba2

Author: stamblerre

cmd/bundle/main.go

@@ -228,6 +228,7 @@ func bundle(src, dst, dstpkg, prefix, buildTags string) ([]byte, error) {
 
 	var out bytes.Buffer
 	if buildTags != "" {
+		fmt.Fprintf(&out, "//go:build %s\n", buildTags)
 		fmt.Fprintf(&out, "// +build %s\n\n", buildTags)
 	}
 

cmd/bundle/testdata/out.golden

@@ -1,3 +1,4 @@
+//go:build tag
 // +build tag
 
 // Code generated by golang.org/x/tools/cmd/bundle. DO NOT EDIT.

cmd/callgraph/main_test.go

@@ -4,8 +4,8 @@
 
 // No testdata on Android.
 
-// +build !android
-// +build go1.11
+//go:build !android && go1.11
+// +build !android,go1.11
 
 package main
 

cmd/cover/cover_test.go

@@ -4,6 +4,7 @@
 
 // No testdata on Android.
 
+//go:build !android
 // +build !android
 
 package main_test

cmd/fiximports/main_test.go

@@ -4,6 +4,7 @@
 
 // No testdata on Android.
 
+//go:build !android
 // +build !android
 
 package main

cmd/getgo/download.go

@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
+//go:build !plan9
 // +build !plan9
 
 package main

cmd/getgo/download_test.go

@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
+//go:build !plan9
 // +build !plan9
 
 package main

cmd/getgo/main.go

@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
+//go:build !plan9
 // +build !plan9
 
 // The getgo command installs Go to the user's system.

cmd/getgo/main_test.go

@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
+//go:build !plan9
 // +build !plan9
 
 package main

cmd/getgo/path.go

@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
+//go:build !plan9
 // +build !plan9
 
 package main