gopls/internal/protocol/command: remove the redundant gopls.test command

As discussed in golang/go#67920, this command is no longer necessary.
Remove it, since it does not follow our pattern for command arguments.

Fixes golang/go#67920

Change-Id: Ia87535e333a35912247ff37f7a6dfb65f11f0745
Reviewed-on: https://go-review.googlesource.com/c/tools/+/642616
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Alan Donovan <[email protected]>
Auto-Submit: Alan Donovan <[email protected]>

Author: findleyr

gopls/internal/cmd/codelens.go

@@ -44,8 +44,8 @@ Example:
 
 	$ gopls codelens a_test.go                     # list code lenses in a file
 	$ gopls codelens a_test.go:10                  # list code lenses on line 10
-	$ gopls codelens a_test.go gopls.test          # list gopls.test commands
-	$ gopls codelens -exec a_test.go:10 gopls.test # run a specific test
+	$ gopls codelens a_test.go "run test"          # list gopls.run_tests commands
+	$ gopls codelens -exec a_test.go:10 "run test" # run a specific test
 
 codelens-flags:
 `)

gopls/internal/cmd/integration_test.go

@@ -213,8 +213,8 @@ func TestFail(t *testing.T) { t.Fatal("fail") }
 	{
 		res := gopls(t, tree, "codelens", "./a/a_test.go")
 		res.checkExit(true)
-		res.checkStdout(`a_test.go:3: "run test" \[gopls.test\]`)
-		res.checkStdout(`a_test.go:4: "run test" \[gopls.test\]`)
+		res.checkStdout(`a_test.go:3: "run test" \[gopls.run_tests\]`)
+		res.checkStdout(`a_test.go:4: "run test" \[gopls.run_tests\]`)
 	}
 	// no codelens with title/position
 	{

gopls/internal/cmd/usage/codelens.hlp

@@ -19,8 +19,8 @@ Example:
 
 	$ gopls codelens a_test.go                     # list code lenses in a file
 	$ gopls codelens a_test.go:10                  # list code lenses on line 10
-	$ gopls codelens a_test.go gopls.test          # list gopls.test commands
-	$ gopls codelens -exec a_test.go:10 gopls.test # run a specific test
+	$ gopls codelens a_test.go "run test"          # list gopls.run_tests commands
+	$ gopls codelens -exec a_test.go:10 "run test" # run a specific test
 
 codelens-flags:
   -d,-diff

gopls/internal/golang/code_lens.go

@@ -47,13 +47,19 @@ func runTestCodeLens(ctx context.Context, snapshot *cache.Snapshot, fh file.Hand
 	}
 	puri := fh.URI()
 	for _, fn := range testFuncs {
-		cmd := command.NewTestCommand("run test", puri, []string{fn.name}, nil)
+		cmd := command.NewRunTestsCommand("run test", command.RunTestsArgs{
+			URI:   puri,
+			Tests: []string{fn.name},
+		})
 		rng := protocol.Range{Start: fn.rng.Start, End: fn.rng.Start}
 		codeLens = append(codeLens, protocol.CodeLens{Range: rng, Command: cmd})
 	}
 
 	for _, fn := range benchFuncs {
-		cmd := command.NewTestCommand("run benchmark", puri, nil, []string{fn.name})
+		cmd := command.NewRunTestsCommand("run benchmark", command.RunTestsArgs{
+			URI:        puri,
+			Benchmarks: []string{fn.name},
+		})
 		rng := protocol.Range{Start: fn.rng.Start, End: fn.rng.Start}
 		codeLens = append(codeLens, protocol.CodeLens{Range: rng, Command: cmd})
 	}
@@ -72,7 +78,10 @@ func runTestCodeLens(ctx context.Context, snapshot *cache.Snapshot, fh file.Hand
 		for _, fn := range benchFuncs {
 			benches = append(benches, fn.name)
 		}
-		cmd := command.NewTestCommand("run file benchmarks", puri, nil, benches)
+		cmd := command.NewRunTestsCommand("run file benchmarks", command.RunTestsArgs{
+			URI:        puri,
+			Benchmarks: benches,
+		})
 		codeLens = append(codeLens, protocol.CodeLens{Range: rng, Command: cmd})
 	}
 	return codeLens, nil

gopls/internal/golang/codeaction.go

@@ -803,7 +803,11 @@ func goTest(ctx context.Context, req *codeActionsRequest) error {
 		return nil
 	}
 
-	cmd := command.NewTestCommand("Run tests and benchmarks", req.loc.URI, tests, benchmarks)
+	cmd := command.NewRunTestsCommand("Run tests and benchmarks", command.RunTestsArgs{
+		URI:        req.loc.URI,
+		Tests:      tests,
+		Benchmarks: benchmarks,
+	})
 	req.addCommandAction(cmd, false)
 	return nil
 }

gopls/internal/protocol/command/command_gen.go

@@ -47,19 +47,7 @@ type Interface interface {
 	// Applies a fix to a region of source code.
 	ApplyFix(context.Context, ApplyFixArgs) (*protocol.WorkspaceEdit, error)
 
-	// Test: Run test(s) (legacy)
-	//
-	// Runs `go test` for a specific set of test or benchmark functions.
-	//
-	// This command is asynchronous; wait for the 'end' progress notification.
-	//
-	// This command is an alias for RunTests; the only difference
-	// is the form of the parameters.
-	//
-	// TODO(adonovan): eliminate it.
-	Test(context.Context, protocol.DocumentURI, []string, []string) error
-
-	// Test: Run test(s)
+	// RunTests: Run tests
 	//
 	// Runs `go test` for a specific set of test or benchmark functions.
 	//

gopls/internal/protocol/command/interface.go

@@ -683,15 +683,6 @@ func dropDependency(pm *cache.ParsedModule, modulePath string) ([]protocol.TextE
 	return protocol.EditsFromDiffEdits(pm.Mapper, diff)
 }
 
-// Test is an alias for RunTests (with splayed arguments).
-func (c *commandHandler) Test(ctx context.Context, uri protocol.DocumentURI, tests, benchmarks []string) error {
-	return c.RunTests(ctx, command.RunTestsArgs{
-		URI:        uri,
-		Tests:      tests,
-		Benchmarks: benchmarks,
-	})
-}
-
 func (c *commandHandler) Doc(ctx context.Context, args command.DocArgs) (protocol.URI, error) {
 	if args.Location.URI == "" {
 		return "", errors.New("missing location URI")