[gopls-release-branch.0.7] internal/lsp: remove duplicated loop that copies IDs

This logic was duplicated as part of the invalid metadata CL.
I believe the loop on L1873 is the intended behavior.

Change-Id: I93ceb3da4045f0536be7dc9da7cecc4323e14a92
Reviewed-on: https://go-review.googlesource.com/c/tools/+/339112
Trust: Rebecca Stambler <[email protected]>
Run-TryBot: Robert Findley <[email protected]>
gopls-CI: kokoro <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
(cherry picked from commit 45eff0f)
Reviewed-on: https://go-review.googlesource.com/c/tools/+/339096
Run-TryBot: Rebecca Stambler <[email protected]>

Author: stamblerre

internal/lsp/cache/snapshot.go

@@ -1843,20 +1843,6 @@ func (s *snapshot) clone(ctx, bgCtx context.Context, changes map[span.URI]*fileC
 			shouldLoad: v.shouldLoad || invalidateMetadata,
 		}
 	}
-	// Copy the URI to package ID mappings, skipping only those URIs whose
-	// metadata will be reloaded in future calls to load.
-	for k, ids := range s.ids {
-		var newIDs []packageID
-		for _, id := range ids {
-			if invalidateMetadata, ok := idsToInvalidate[id]; invalidateMetadata && ok {
-				continue
-			}
-			newIDs = append(newIDs, id)
-		}
-		if len(newIDs) != 0 {
-			result.ids[k] = newIDs
-		}
-	}
 
 	// Copy the set of initially loaded packages.
 	for id, pkgPath := range s.workspacePackages {