gopls/internal/server: remove tempDir field

It wasn't used for anything!

Fixes golang/go#74373

Change-Id: Ie867398d508f1094c633945ba5330cb32a2b6dbe
Reviewed-on: https://go-review.googlesource.com/c/tools/+/683995
Reviewed-by: Robert Findley <[email protected]>
Auto-Submit: Alan Donovan <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>

Author: adonovan

gopls/internal/server/general.go

@@ -54,20 +54,6 @@ func (s *server) Initialize(ctx context.Context, params *protocol.ParamInitializ
 	s.state = serverInitializing
 	s.stateMu.Unlock()
 
-	// For uniqueness, use the gopls PID rather than params.ProcessID (the client
-	// pid). Some clients might start multiple gopls servers, though they
-	// probably shouldn't.
-	pid := os.Getpid()
-	s.tempDir = filepath.Join(os.TempDir(), fmt.Sprintf("gopls-%d.%s", pid, s.session.ID()))
-	err := os.Mkdir(s.tempDir, 0700)
-	if err != nil {
-		// MkdirTemp could fail due to permissions issues. This is a problem with
-		// the user's environment, but should not block gopls otherwise behaving.
-		// All usage of s.tempDir should be predicated on having a non-empty
-		// s.tempDir.
-		event.Error(ctx, "creating temp dir", err)
-		s.tempDir = ""
-	}
 	s.progress.SetSupportsWorkDoneProgress(params.Capabilities.Window.WorkDoneProgress)
 
 	options := s.Options().Clone()
@@ -642,11 +628,6 @@ func (s *server) Shutdown(ctx context.Context) error {
 		// drop all the active views
 		s.session.Shutdown(ctx)
 		s.state = serverShutDown
-		if s.tempDir != "" {
-			if err := os.RemoveAll(s.tempDir); err != nil {
-				event.Error(ctx, "removing temp dir", err)
-			}
-		}
 	}
 	return nil
 }

gopls/internal/server/server.go

@@ -86,8 +86,6 @@ type server struct {
 
 	session *cache.Session
 
-	tempDir string
-
 	// changedFiles tracks files for which there has been a textDocument/didChange.
 	changedFilesMu sync.Mutex
 	changedFiles   map[protocol.DocumentURI]unit