gopls: Update the condition for assembly reference checks and add test cases.

Update the condition for identifying assembly files to allow only ref and data types.
Remove Go definition references from the goasm reference process.
Add test files for different types of reference relationships between asm and Go.

Updates golang/go#71754

Author: groot-guo

gopls/internal/cache/xrefs/xrefs.go

@@ -120,14 +120,20 @@ func Index(files []*parsego.File, pkg *types.Package, info *types.Info, asmFiles
 			if id.Kind != asm.Data && id.Kind != asm.Ref {
 				continue
 			}
-			_, name, ok := morestrings.CutLast(id.Name, ".")
+			pkgpath, name, ok := morestrings.CutLast(id.Name, ".")
 			if !ok {
 				continue
 			}
+			if pkgpath != pkg.Path() {
+				// Reference to symbol in another package.
+				// TODO(grootguo): implement this case. See similar logic in
+				// golang.lookupDocLinkSymbol, which also does not yet handle this case.
+				// See also goasm.Definitions, which loads a package by path from the
+				// forward transitive closure.
+				continue
+			}
 			obj := pkg.Scope().Lookup(name)
 			if obj == nil {
-				// TODO(grootguo): If the object is not found in the current package,
-				// consider handling cross-package references.
 				continue
 			}
 			objects := getObjects(pkg)
@@ -137,7 +143,7 @@ func Index(files []*parsego.File, pkg *types.Package, info *types.Info, asmFiles
 				gobObj = &gobObject{Path: objectpath.Path(obj.Name())}
 				objects[obj] = gobObj
 			}
-			if rng, err := af.NodeRange(id); err == nil {
+			if rng, err := af.IdentRange(id); err == nil {
 				gobObj.Refs = append(gobObj.Refs, gobRef{
 					FileIndex: fileIndex,
 					Range:     rng,
@@ -174,9 +180,7 @@ func Index(files []*parsego.File, pkg *types.Package, info *types.Info, asmFiles
 // to any object in the target set. Each object is denoted by a pair
 // of (package path, object path).
 func Lookup(mp *metadata.Package, data []byte, targets map[metadata.PackagePath]map[objectpath.Path]struct{}) (locs []protocol.Location) {
-	var (
-		packages []*gobPackage
-	)
+	var packages []*gobPackage
 	packageCodec.Decode(data, &packages)
 	for _, gp := range packages {
 		if objectSet, ok := targets[gp.PkgPath]; ok {

gopls/internal/goasm/references.go

@@ -27,7 +27,7 @@ func References(ctx context.Context, snapshot *cache.Snapshot, fh file.Handle, p
 	ctx, done := event.Start(ctx, "goasm.References")
 	defer done()
 
-	mps, err := snapshot.MetadataForFile(ctx, fh.URI())
+	mps, err := snapshot.MetadataForFile(ctx, fh.URI(), false)
 	if err != nil {
 		return nil, err
 	}
@@ -94,14 +94,14 @@ func References(ctx context.Context, snapshot *cache.Snapshot, fh file.Handle, p
 		}
 	}
 
+	if !includeDeclaration {
+		return locations, nil
+	}
 	for _, asmFile := range pkg.AsmFiles() {
 		for _, id := range asmFile.Idents {
 			if id.Name == found.Name &&
 				(id.Kind == asm.Data || id.Kind == asm.Ref) {
-				if id.Kind == asm.Data && !includeDeclaration {
-					continue
-				}
-				if loc, err := asmFile.NodeLocation(id); err == nil {
+				if loc, err := asmFile.IdentLocation(id); err == nil {
 					locations = append(locations, loc)
 				}
 			}

gopls/internal/golang/references.go

@@ -39,6 +39,7 @@ import (
 	"golang.org/x/tools/gopls/internal/util/safetoken"
 	"golang.org/x/tools/internal/astutil"
 	"golang.org/x/tools/internal/event"
+	"golang.org/x/tools/internal/typesinternal"
 )
 
 // References returns a list of all references (sorted with
@@ -625,10 +626,13 @@ func localReferences(pkg *cache.Package, targets map[types.Object]bool, correspo
 			if obj == nil {
 				continue
 			}
+			if !typesinternal.IsPackageLevel(obj) {
+				continue
+			}
 			if !matches(obj) {
 				continue
 			}
-			if rng, err := pgf.NodeRange(id); err == nil {
+			if rng, err := pgf.IdentRange(id); err == nil {
 				asmLocation := protocol.Location{
 					URI:   pgf.URI,
 					Range: rng,

gopls/internal/test/marker/testdata/references/asm.txt

@@ -1,8 +1,5 @@
 
 
--- go.mod --
-module example.com
-go 1.24
 
 -- example/label_example.s --
 TEXT ·JumpDemo(SB), $0-0

gopls/internal/test/marker/testdata/references/asm_go.txt

@@ -25,13 +25,13 @@ var myGlobal int64 //@loc(defMyGlobalGo, "myGlobal"), refs("myGlobal", defMyGlob
 var _ = myGlobal   //@loc(refMyGlobalGo, "myGlobal")
 
 -- go_call_asm/example_asm.s --
-TEXT ·Add(SB), $0-24 //@loc(defAddAsm, "·Add"), refs("Add", defAddGo, callAddGo)
+TEXT ·Add(SB), $0-24 //@refs("Add", defAddGo, callAddGo)
     MOVQ a+0(FP), AX
     ADDQ b+8(FP), AX
     RET
 
-DATA ·myGlobal+0(SB)/8, $42 
-GLOBL ·myGlobal(SB), NOPTR, 8 
+DATA ·myGlobal+0(SB)/8, $42
+GLOBL ·myGlobal(SB), NOPTR, 8
 TEXT ·UseGlobal(SB), $0-0
     MOVQ ·myGlobal(SB), AX //@loc(refMyGlobal, "·myGlobal")
     RET
@@ -49,3 +49,15 @@ TEXT ·CallSub(SB), $0-16
     MOVQ BX, b+8(FP)
     CALL ·Sub(SB) //@loc(callSubAsm, "·Sub")
     RET
+
+// When defined in another package, it will not be processed.
+-- example/func.go --
+package example
+
+func Add(a, b int) int 
+func UseAdd() int {
+    return Add(1, 2) 
+}
+var myGlobal int64 
+var _ = myGlobal   
+

gopls/internal/util/asm/parse.go

@@ -54,12 +54,13 @@ type File struct {
 	// future in which analyzers can report diagnostics in .s files.
 }
 
-func (f *File) NodeRange(ident Ident) (protocol.Range, error) {
+// IdentRange returns the protocol.Range for the identifier in this file.
+func (f *File) IdentRange(ident Ident) (protocol.Range, error) {
 	return f.Mapper.OffsetRange(ident.Offset, ident.Offset+ident.OrigLen)
 }
 
-// NodeLocation returns a protocol Location for the ast.Node interval in this file.
-func (f *File) NodeLocation(ident Ident) (protocol.Location, error) {
+// IdentLocation returns a protocol Location for the identifier in this file.
+func (f *File) IdentLocation(ident Ident) (protocol.Location, error) {
 	return f.Mapper.OffsetLocation(ident.Offset, ident.Offset+ident.OrigLen)
 }