extension/src/goLint: enabled to override path-mode flag

Currently, users can't override or disable any flags added by vscode-go. However, in some environments, the `path-mode` flag needs to be overridden. (#3750 (comment))
The flags related to the output format shouldn't be changed so that vscode-go can parse them correctly. Thus, I enable overriding the `path-mode` flag.

Fixes #3750

Change-Id: I6258c7054ef91137c13d566744ac01a33caf0bd4
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/667735
kokoro-CI: kokoro <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>
Reviewed-by: Hongxiang Jiang <[email protected]>
Auto-Submit: Hongxiang Jiang <[email protected]>

Author: logica0419

CHANGELOG.md

@@ -13,6 +13,7 @@ diff between options locally discovered and options available for download.
   * Added a new lint tool, `golangci-lint-v2`. It's added as an installable tool, so you can install it via the `Go: Install/Update Tools` command.
   * You can switch v1 and v2 per workspace by using `golangci-lint` and `golangci-lint-v2` option. You must keep the `golangci-lint` executable version on your machine to v1 for that.
   * You can also use `golangci-lint` executable updated to v2. Just keep using the `golangci-lint` option for that.
+  * The `path-mode` flag set by vscode-go can be overridden by the`go.lintFlags` option.
   * Looking for a way to format your code with golangci-lint v2 on VS Code? Check the [golangci-lint documentation](https://golangci-lint.run/welcome/integrations/#visual-studio-code).
 
 ### Fixes

extension/src/goLint.ts

@@ -121,7 +121,7 @@ export async function goLint(
 			const { moduleVersion } = await inspectGoToolVersion(getBinPath(lintTool));
 			// if moduleVersion is undefined, treat it as version=1
 			// if moduleVersion is higher than v1 (v2, v3...), treat it as version=2
-			!moduleVersion || moduleVersion.startsWith('v1') ? (version = 1) : (version = 2);
+			version = !moduleVersion || moduleVersion.startsWith('v1') ? 1 : 2;
 		}
 
 		// append common flags
@@ -139,10 +139,10 @@ export async function goLint(
 					// print only file:number:column
 					args.push('--print-issued-lines=false');
 				}
-				if (args.indexOf('--out-format=colored-line-number') === -1) {
+				if (args.indexOf('--out-format=line-number') === -1) {
 					// print file:number:column.
 					// Explicit override in case .golangci.yml calls for a format we don't understand
-					args.push('--out-format=colored-line-number');
+					args.push('--out-format=line-number');
 				}
 				break;
 
@@ -160,12 +160,7 @@ export async function goLint(
 					// Explicit override in case .golangci.yml calls for a format we don't understand
 					args.push('--output.text.path=stdout');
 				}
-				if (args.indexOf('--output.text.colors=true') === -1) {
-					// print file:number:column.
-					// Explicit override in case .golangci.yml calls for a format we don't understand
-					args.push('--output.text.colors=true');
-				}
-				if (args.indexOf('--path-mode=abs') === -1) {
+				if (!args.some((v) => v.startsWith('--path-mode='))) {
 					// print file name as absolute path
 					args.push('--path-mode=abs');
 				}