[release] prepare v0.36.0 release

ce9ddf8 CHANGELOG.md: draft v0.36.0 release note
7055f45 docs/features: add "Go Test: Profile" feature screenshot
2352869 test/gopls: add time out in language client stop
40074a4 src/goToolsInformation: update gopls latest version
67e3a26 src/language/goLanguageServer: fix signature help trigger injection
318539d src/goTest/profile: fix tree view action
02fafd6 src/goMain: show warning message about go.enableCodeLens.references
8c40422 tools: update golangci-lint default version to v1.50.1
82cad22 package.json: update [email protected]
bf5789c vscode-go: remove the 'references' codelens
ea6fed7 tools/goplssetting: trim space after generating package.json
2918cb4 src/goToolsInformation: fix go-outline version
2e739cc package.json: update gopls settings to match v0.10.0-pre.1
2a6a178 src/goTools: remove unneeded import
4f3a371 src/goTools: specify gofumpt/golangci-lint versions for old go
fc6d532 snippet/go.json: add code snippet for variable block
1ccf637 src/goToolsInformation: update gopls latest version
8253459 src/goInstallTools.ts: install tools command UI displays pinned versions
23f22eb docs: update docs for pinned command-line tools
8d7fc9a src/goToolsInformation.ts: pin all third party tool versions
3063e68 src/goVulncheck: copy codicon resources to media
f39f7ed src/goVulncheck: add "Current Module" option
62516a4 media/vulncheckView: use codicons to distinguish severity
cf7c1cc package.json: rename vulncheck command
17f6b7a media/vulncheckView.js: simplify the run log section.
8cef5ae media/vulncheckView: organize unaffecting vulns by vuln ids
4b658d3 src/goVulncheck: add feedback link
4b6ce1f all: fix some typos
c41fb17 README.md: Clean up of README sections, link fix
4298b52 src/goTest: open debug repl when running debug test

Change-Id: Ia50aac58cf1167d2c99b0f42ed3ed3b17d900205

Author: hyangah

CHANGELOG.md

@@ -1,3 +1,21 @@
+## v0.36.0 - 4 Nov, 2022
+A list of all issues and changes can be found in the [v0.36.0 milestone](https://github.com/golang/vscode-go/milestone/52) and [commit history](https://github.com/golang/vscode-go/compare/v0.35.2...v0.36.0).
+
+### Changes
+- From this release, the extension will download specific versions of 3rd party tools installed with the "Go: Install/Update Tools" command. This is to enhance stability and security. The "Go: Install/Upate Tools" command will present the versions the extension will install. To install a different version of a tool, use `go install` command from the terminal instead. ([Issue 1850](https://github.com/golang/vscode-go/issues/1850))
+- The default gopls version was updated to v0.10.1 and the settings were updated accordingly. See the [release note of gopls v0.10.0](https://github.com/golang/tools/releases/tag/gopls%2Fv0.10.0) to learn about notable changes and new features.
+- Typing `vars` will now offer a completion snippet that expands it to a `var (...)` block containing multiple variables. ([PR 2481](https://github.com/golang/vscode-go/pull/2481))
+- The setting to enable the "references" codelens, `go.enableCodeLens.references`, is now hidden. The feature remained broken for a while, so we plan to remove it in a future release. Please see [Issue 2509](https://github.com/golang/vscode-go/issues#2509) for details.
+- When debugging tests, the extension will open the "Debug Console". ([Issue 2409](https://github.com/golang/vscode-go/issues/2409))
+
+### Fixes
+- Fixed [Issue 2525](https://github.com/golang/vscode-go/issues/2525) that prevented triggering of parameter hints after method autocompletion. Users can enable/disable this parameter hints popup with the `"editor.parameterHints.enabled"` setting.
+- Fixed [test profie feature](https://github.com/golang/vscode-go/wiki/features#profiling) ([CL 440530](https://go-review.googlesource.com/c/vscode-go/+/440530)).
+- Removed dev dependency affected by CVE-2022-3517.
+
+### Thanks
+Thank you for your contribution, @suzmue, @fatoboist, @cuishuang, @jamalc, @karthikraobr, @pjweinbgo, @firelizzard18, @hyangah!
+
 ## v0.35.2 - 15 Aug, 2022
 A list of all issues and changes can be found in the [v0.35.2 milestone](https://github.com/golang/vscode-go/milestone/51) and [commit history](https://github.com/golang/vscode-go/compare/v0.35.1...v0.35.2).
 

README.md

@@ -51,14 +51,23 @@ You are ready to Go :-)    🎉🎉🎉
 
 ## What's next
 
-* Explore more [features](#features) of the VS Code Go extension.
-* Learn how to [customize](#customization) your settings.
-* Solve issues with
-  [Troubleshooting](https://github.com/golang/vscode-go/wiki/troubleshooting).
+* Explore more [features][full feature breakdown] of the VS Code Go extension.
+* View the
+  [settings documentation](https://github.com/golang/vscode-go/wiki/settings)
+	and [advanced topics](https://github.com/golang/vscode-go/wiki/advanced) to
+	customize the extension.
+* View the [tools documentation](https://github.com/golang/vscode-go/wiki/tools)
+  for a complete list of tools the VS Code Go extension depends on.
+* Solve issues with the
+  [general troubleshooting](https://github.com/golang/vscode-go/wiki/troubleshooting)
+	and [debugging troubleshooting](https://github.com/golang/vscode-go/wiki/debugging#troubleshooting)
+	guides.
 * [file an issue](https://github.com/golang/vscode-go/issues/new/choose) for
   problems with the extension.
 * Start a [GitHub discussion](https://github.com/golang/vscode-go/discussions)
   or get help on [Stack Overflow].
+* Explore Go language resources on [go.dev/learn](https://go.dev/learn) and
+  [golang.org/help](https://golang.org/help).
 
 If you are new to Go, [this article](https://golang.org/doc/code.html) provides
 the overview on Go code organization and basic `go` commands. Watch ["Getting
@@ -104,28 +113,14 @@ by turning on [Gopls' `ui.semanticTokens` setting](https://github.com/golang/vsc
     "gopls": { "ui.semanticTokens": true }
     ```
 
-## Tools
-
-The extension uses a few command-line tools developed by the Go community. In
-particular, `go`, `gopls`, and `dlv` **must** be installed for this extension
-to work correctly. See the [tools documentation](https://github.com/golang/vscode-go/wiki/tools) for a complete
-list of tools the extension depends on.
-
-In order to locate these command-line tools, the extension searches
-`GOPATH/bin` and directories specified in the `PATH` environment variable (or
-`Path` on Windows) with which the VS Code process has started. If the tools are
-not found, the extension will prompt you to install the missing tools and show
-the "⚠️ Analysis Tools Missing" warning in the bottom right corner. Please
-install them by responding to the warning notification, or by manually running
-the [`Go: Install/Update Tools` command].
-
 ## Setting up your workspace
 
-[Go modules](https://golang.org/ref/mod) are how Go manages dependencies in
+The VS Code Go extension supports both `GOPATH` and Go modules modes.
+
+[Go modules](https://golang.org/ref/mod) are used to manage dependencies in
 recent versions of Go. Modules replace the `GOPATH`-based approach to specifying
 which source files are used in a given build, and they are the default build
-mode in go1.16+. While this extension continues to support both Go modules and
-`GOPATH` modes, we highly recommend Go development in module mode. If you are
+mode in go1.16+. We highly recommend Go development in module mode. If you are
 working on existing projects, please consider migrating to modules.
 
 Unlike the traditional `GOPATH` mode, module mode does not require the workspace
@@ -135,34 +130,8 @@ tree's root directory.
 
 Your project may involve one or more modules. If you are working with multiple
 modules or uncommon project layouts, you will need to configure your workspace
-by using [Workspace Folders]. Please see this [documentation about supported
-workspace layouts].
-
-## Customization
-
-The extension needs no configuration and should work out of the box. However,
-you may wish to adjust settings to customize its behavior. Please see the
-[settings documentation](https://github.com/golang/vscode-go/wiki/settings) for a comprehensive list of settings.
-See [advanced topics](https://github.com/golang/vscode-go/wiki/advanced) for further customizations and unique
-use cases.
-
-## Troubleshooting
-
-If the extension isn't working as you expect, you can take a look at our
-troubleshooting guides. There is one for [general
-troubleshooting](https://github.com/golang/vscode-go/wiki/troubleshooting), and another specifically for
-[troubleshooting the debugging feature](https://github.com/golang/vscode-go/wiki/debugging#troubleshooting).
-
-## Ask for help
-
-If the troubleshooting guides did not resolve the issue, please reach out to us
-by [filing an issue](https://github.com/golang/vscode-go/issues/new/choose),
-[starting a GitHub discussion](https://github.com/golang/vscode-go/discussions),
-or by asking a question on [Stack Overflow].
-
-Also, you can take a look at [go.dev/learn](https://go.dev/learn) and
-[golang.org/help](https://golang.org/help) for more general guidance on using
-Go.
+by using [Workspace Folders]. See the
+[Supported workspace layouts documentation] for more information.
 
 ## Preview version
 
@@ -174,9 +143,10 @@ nightly build of this extension. Learn how to install it in by reading the
 
 We welcome your contributions and thank you for working to improve the Go
 development experience in VS Code. If you would like to help work on the VS Code
-Go extension, please see our [contribution guide](https://github.com/golang/vscode-go/wiki/contributing). It
-explains how to build and run the extension locally, and describes the process
-of sending a contribution.
+Go extension, see our
+[contribution guide](https://github.com/golang/vscode-go/wiki/contributing) to
+learn how to build and run the VS Code Go extension locally and contribute to
+the project.
 
 ## Code of Conduct
 
@@ -204,5 +174,5 @@ conduct-related issue, please mail [email protected].
 [full feature breakdown]: https://github.com/golang/vscode-go/wiki/features
 [workspace documentation]: https://github.com/golang/tools/blob/master/gopls/doc/workspace.md
 [`Go: Install/Update Tools` command]: https://github.com/golang/vscode-go/wiki/commands#go-installupdate-tools
-[documentation about supported workspace layouts]: https://github.com/golang/tools/blob/master/gopls/doc/workspace.md
+[Supported workspace layouts documentation]: https://github.com/golang/tools/blob/master/gopls/doc/workspace.md
 [Workspace Folders]: https://code.visualstudio.com/docs/editor/multi-root-workspaces

docs/advanced.md

@@ -61,6 +61,11 @@ etc.). The `"go.alternateTools"` setting provides a way to configure the
 extension to use different tool location, for example a wrapper with a different
 name.
 
+The extension uses pinned versions of command-line tools. See the pinned versions
+in tools information
+[here](https://github.com/golang/vscode-go/blob/master/src/goToolsInformation.ts).
+To use an alternate version of a tool install it manually with with go install.
+
 ## Using a custom linter
 
 A commonly customized feature is the linter, which is the tool used to provide

docs/commands.md

@@ -79,6 +79,10 @@ Run a test and capture a profile
 
 Delete selected profile
 
+### `Go: Show pprof file`
+
+Internal use. Open a pprof profile file.
+
 ### `Go: Benchmark Package`
 
 Runs all benchmarks in the package of the current file.
@@ -263,6 +267,6 @@ Edit the Go Env for the active workspace.
 
 Reset the Go Env for the active workspace.
 
-### `Go: Run Vulncheck (Experimental)`
+### `Go: Run Vulncheck (Preview)`
 
-Run go vulncheck.
+Run vulnerability check. See https://pkg.go.dev/golang.org/x/vuln/cmd/govulncheck for more details about the analysis.

docs/contributing.md

@@ -69,13 +69,13 @@ You can run `npm run lint` on the command-line to check for lint errors in your
 
 ### Run
 
-To run the extension with your patch, open the Run view (`Ctrl+Shift+D`), select `Launch Extension`, and click the Play button (`F5`).
+To run the extension with your patch, open the Run view (`Ctrl+Shift+D` or `⌘+⇧+D`), select `Launch Extension`, and click the Play button (`F5`).
 
 This will open a new VS Code window with the title `[Extension Development Host]`. You can then open a folder that contains Go code and try out your changes.
 
 You can also set breakpoints to debug your change.
 
-If you make subsequent edits in the codebase, you can reload (`Ctrl+R`) the `[Extension Development Host]` instance of VS Code, which will load the new code. The debugger will automatically reattach.
+If you make subsequent edits in the codebase, you can reload (`Ctrl+R` or `⌘+R`) the `[Extension Development Host]` instance of VS Code, which will load the new code. The debugger will automatically reattach.
 
 ## Test
 

docs/features.md

@@ -35,6 +35,7 @@ This document describes the features supported by this extension.
   * [Run your code](#run-your-code)
   * [Test and benchmark](#test-and-benchmark)
   * [Code coverage](#code-coverage)
+  * [Profiling](#profiling)
 * [Debug your code](#debugging)
 * [Other](#other)
   * [Go Playground](#go-playground)
@@ -220,14 +221,22 @@ Behind the scenes, the `Debug: Start without Debugging` command calls `go run`.
 
 ### Test and benchmark
 
-[Test UI](https://code.visualstudio.com/api/extension-guides/testing) and [Code lenses](https://code.visualstudio.com/blogs/2017/02/12/code-lens-roundup) allow users to easily run tests and benchmarks for a given function, file, package, or workspace. Alternatively, the same functionality is available through a set of commands: [`Go: Test Function At Cursor`](commands.md#go-test-function-at-cursor), [`Go: Test File`](commands.md#go-test-file), [`Go: Test Package`](commands.md#go-test-package), and [`Go: Test All Packages in Workspace`](commands.md#go-test-all-packages-in-workspace).
+[Test UI](https://code.visualstudio.com/api/extension-guides/testing) and [Code lenses](https://code.visualstudio.com/blogs/2017/02/12/code-lens-roundup) allow users to easily run tests, benchmarks, and profiles for a given function, file, package, or workspace.
+
+Alternatively, the same functionality is available through a set of commands: [`Go: Test Function At Cursor`](commands.md#go-test-function-at-cursor), [`Go: Test File`](commands.md#go-test-file), [`Go: Test Package`](commands.md#go-test-package), and [`Go: Test All Packages in Workspace`](commands.md#go-test-all-packages-in-workspace).
 
 <div style="text-align: center;"><img src="images/testexplorer.gif" alt="Testing UI" style="width: 75%"> </div>
 
 ### Code Coverage
 
 Show code coverage in the editor, either after running a test or on-demand. This can be done via the commands: [`Go: Apply Cover Profile`](commands.md#go-apply-cover-profile) and [`Go: Toggle Test Coverage in Current Package`](commands.md#go-toggle-test-coverage-in-current-package).
 
+### Profiling
+
+"Go Test: Profile" menu in [Test UI](https://code.visualstudio.com/api/extension-guides/testing) collects CPU/Memory/Mutex profiles and allows visualizing them using pprof (`go tool pprof`).
+
+<div style="text-align: center;"><img src="images/testexplorer-pprof.gif" alt="Profiling" style="width: 75%"> </div>
+
 ## [Debugging](debugging.md)
 
 This extension offers debugging of Go programs. See the [debugging documentation](debugging.md) for more information.