Skip to content

Commit 170d3dc

Browse files
hyangahsuzmue
authored andcommitted
src/goTools: install [email protected] when building with go1.18
[email protected].* requires go1.19+. Change-Id: I1299b276f8c39fc7ea6f38a0ddf9ba3108ca759f Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/470475 Run-TryBot: Hyang-Ah Hana Kim <[email protected]> Reviewed-by: Suzy Mueller <[email protected]> TryBot-Result: kokoro <[email protected]> (cherry picked from commit d7419f4) Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/470636 Run-TryBot: Suzy Mueller <[email protected]> Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
1 parent 17494ce commit 170d3dc

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/goTools.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ export function getImportPathWithVersion(
8888
}
8989
if (tool.name === 'staticcheck') {
9090
if (goVersion.lt('1.17')) return importPath + '@v0.2.2';
91-
if (goVersion.lt('1.18')) return importPath + '@v0.3.3';
91+
if (goVersion.lt('1.19')) return importPath + '@v0.3.3';
9292
}
9393
if (tool.name === 'gofumpt') {
9494
if (goVersion.lt('1.18')) return importPath + '@v0.2.1';

tools/installtools/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ var tools = []struct {
4747
{"github.com/sqs/goreturns", "", false, nil},
4848
{"github.com/uudashr/gopkgs/v2/cmd/gopkgs", "", false, nil},
4949
{"github.com/zmb3/gogetdoc", "", false, nil},
50-
{"honnef.co/go/tools/cmd/staticcheck", "", false, []finalVersion{{16, "v0.2.2"}, {17, "v0.3.3"}}},
50+
{"honnef.co/go/tools/cmd/staticcheck", "", false, []finalVersion{{16, "v0.2.2"}, {18, "v0.3.3"}}},
5151
{"golang.org/x/tools/cmd/gorename", "", false, nil},
5252
{"github.com/go-delve/delve/cmd/dlv", "", false, []finalVersion{{16, "v1.8.3"}, {17, "v1.9.1"}}},
5353
}

0 commit comments

Comments
 (0)