build/all.bash: rearrange test order

VSCode modifies package.json while running in the
integration test. It reverts back the package.json
to original, but the revert file write can occur
asynchronously. That affects our document generator
tests following the integration test.

Change the test order so we run the document generator
test before.

Usually, integration test takes long. So, running
this quick documentation consistency test first and
reporting the problem early is better.

Also, change Dockerfile to bring up the container
as non-root user (node created by the node container)

Fixes #2230

Change-Id: I14b2d260f66e8213bdca2125900b5213a45ba8d1
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/405905
Reviewed-by: Jamal Carvalho <[email protected]>
Reviewed-by: Suzy Mueller <[email protected]>

Author: hyangah

build/Dockerfile

@@ -2,7 +2,6 @@
 ARG GOVERSION=1
 FROM golang:${GOVERSION} AS gobuilder
 
-ENV GO111MODULE on
 ENV GOBIN /gobin
 
 # Install other Go tools tests depend on
@@ -12,22 +11,19 @@ RUN go run /scratch/installtools/main.go
 
 FROM node:latest
 
-# Prepare a home directory under workspace.
-RUN mkdir -p /workspace/vscodego
-ENV HOME=/workspace/vscodego
-
 # GO111MODULE=auto
 RUN mkdir /go
 COPY --from=gobuilder /gobin /go/bin
 COPY --from=gobuilder /usr/local/go /usr/local/go
 
 # Add the default GOPATH/bin to the PATH.
 # Add the directories of the go tool chains to PATH.
-ENV PATH /workspace/vscodego/go/bin:/go/bin:/usr/local/go/bin:${PATH}
+ENV PATH /go/bin:/usr/local/go/bin:${PATH}
 ENV DEBIAN_FRONTEND noninteractive
 
 RUN apt-get -qq update && apt-get install -qq -y libnss3 libgtk-3-dev libxss1 libasound2 xvfb libsecret-1-0 jq > /dev/null
 RUN npm install -g typescript vsce
 
+USER node
 WORKDIR /workspace
 ENTRYPOINT ["build/all.bash"]

build/all.bash

@@ -42,27 +42,26 @@ go_binaries_info() {
 }
 
 run_test() {
-  echo "**** Run test ****"
   df -h | grep shm
+
+  echo "**** Run settings generator ****"
+  go run ./tools/generate.go -w=false -gopls=true
+
+  echo "**** Run Go tests ****"
+  go test ./...
+
+  echo "**** Test build ****"
   npm ci
   npm run compile
+
+  echo "**** Run test ****"
   npm run unit-test
   npm test --silent
-  npm run lint
-
-  # BUG(github.com/golang/vscode-go/issues/2230): Disable test temporarily.
-  # echo "**** Run settings generator ****"
-  # go run tools/generate.go -w=false -gopls=true
 
-  echo "**** Check if vsce works ****"
-  vsce package
-
-  echo "**** Run Go tests ****"
-  go test ./...
-  # TODO(hyangah): see if go clean -modcache makes kokoro builder happy
-  go clean -modcache
+  npm run lint
 }
 
+
 run_test_in_docker() {
   echo "**** Building the docker image ***"
   docker build -t vscode-test-env ${GOVERSION:+ --build-arg GOVERSION="${GOVERSION}"} -f ./build/Dockerfile .