[release] src/goMain.ts: reinstate the goroot var interpolation

Add back the feature that resolves ~, ${workspaceFolder},
${workspaceRoot} included in "go.goroot". This feature was available
since 0.6.72, but accidentally lost during the 0.15 dev cycle
when we restructured the handling of `GOROOT`.

Fixes #464

Change-Id: I373cdc8de02d3d1764ca939b6ca6299216a6496e
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/246518
Reviewed-by: Brayden Cloud <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
(cherry picked from commit c6695aa)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/246997

Author: hyangah

src/goMain.ts

@@ -58,7 +58,8 @@ import {
 	getToolsGopath,
 	getWorkspaceFolderPath,
 	handleDiagnosticErrors,
-	isGoPathSet
+	isGoPathSet,
+	resolvePath,
 } from './util';
 import { clearCacheForTools, envPath, fileExists, getCurrentGoRoot, setCurrentGoRoot } from './utils/goPath';
 
@@ -78,7 +79,7 @@ export function activate(ctx: vscode.ExtensionContext) {
 
 	const configGOROOT = getGoConfig()['goroot'];
 	if (!!configGOROOT) {
-		setCurrentGoRoot(configGOROOT);
+		setCurrentGoRoot(resolvePath(configGOROOT));
 	}
 
 	updateGoVarsFromConfig().then(async () => {

src/util.ts

@@ -484,7 +484,7 @@ export function getBinPath(tool: string, useCache = true): string {
 	return getBinPathWithPreferredGopathGoroot(
 		tool,
 		tool === 'go' ? [] : [getToolsGopath(), getCurrentGoPath()],
-		tool === 'go' && cfg.get('goroot') ? cfg.get('goroot') : undefined,
+		tool === 'go' && cfg.get('goroot') ? resolvePath(cfg.get('goroot')) : undefined,
 		selectedGoPath ?? resolvePath(alternateToolPath),
 		useCache
 	);