[release] prepare v0.23.1 release

f641be9 package.json: change the default format tool to goimports
ac61291 package.json: update LSP and DAP libraries
b085ad4 src/config: add toolsEnvVars to the config list to watch
977bb74 src/goTools: explicitly specify staticcheck, gotests package paths
ace0cf7 tools: run gopls setting update in tools/generate.go
68e5a0b src/goModules: fix a bug in formatTool warning prompt
658a52b src/goLanguageServer: show command failure error messages from gopls
fb5bc5b test/integration/goDebug: fix windows tests
a8bf0c2 CHANGELOG.md: v0.23.0 release note
5c340dd src/goDebugFactory: redirect stdout/stderr from dlv to Debug Console
fd03282 src/goLint: switch the default lint tool to staticcheck
a64f4f0 src/config: suppress welcome page & update check in cloud-based ides
0b1ae1d docs/settings.md: sync gopls settings @v0.6.6
f6391a2 src/goLanguageServer: replace [] foldingRange response with undefined
80f450f src/welcome: remove unused variables
808b02f src/goDebugFactory.ts: fix error in exec mode
9fe63c5 welcome: remove gopls announcement from the welcome page

Change-Id: Ic4ff3cb80da274c3806436c1f63ed0a16b0b0837

Author: hyangah

.github/workflows/release-nightly.yml

@@ -57,7 +57,7 @@ jobs:
             go get github.com/sqs/goreturns
             go get github.com/uudashr/gopkgs/v2/cmd/gopkgs
             go get github.com/zmb3/gogetdoc
-            go get golang.org/x/lint/golint
+            go get honnef.co/go/tools/...
             go get golang.org/x/tools/cmd/gorename
             go get golang.org/x/tools/gopls
             go get github.com/cweill/gotests/...

.github/workflows/test-long-all.yml

@@ -53,7 +53,7 @@ jobs:
             go get github.com/sqs/goreturns
             go get github.com/uudashr/gopkgs/v2/cmd/gopkgs
             go get github.com/zmb3/gogetdoc
-            go get golang.org/x/lint/golint
+            go get honnef.co/go/tools/...
             go get golang.org/x/tools/cmd/gorename
             go get golang.org/x/tools/gopls
             go get github.com/cweill/gotests/...

.github/workflows/test-long.yml

@@ -52,7 +52,7 @@ jobs:
             go get github.com/sqs/goreturns
             go get github.com/uudashr/gopkgs/v2/cmd/gopkgs
             go get github.com/zmb3/gogetdoc
-            go get golang.org/x/lint/golint
+            go get honnef.co/go/tools/...
             go get golang.org/x/tools/cmd/gorename
             go get golang.org/x/tools/gopls
             go get github.com/cweill/gotests/...

.github/workflows/test-smoke.yml

@@ -50,7 +50,7 @@ jobs:
             go get github.com/sqs/goreturns
             go get github.com/uudashr/gopkgs/v2/cmd/gopkgs
             go get github.com/zmb3/gogetdoc
-            go get golang.org/x/lint/golint
+            go get honnef.co/go/tools/...
             go get golang.org/x/tools/cmd/gorename
             go get golang.org/x/tools/gopls
             go get github.com/cweill/gotests/...

build/Dockerfile

@@ -26,7 +26,7 @@ COPY --from=gobuilder /usr/local/go /usr/local/go
 ENV PATH /workspace/vscodego/go/bin:/go/bin:/usr/local/go/bin:${PATH}
 ENV DEBIAN_FRONTEND noninteractive
 
-RUN apt-get -qq update && apt-get install -qq -y libnss3 libgtk-3-dev libxss1 libasound2 xvfb libsecret-1-0 > /dev/null
+RUN apt-get -qq update && apt-get install -qq -y libnss3 libgtk-3-dev libxss1 libasound2 xvfb libsecret-1-0 jq > /dev/null
 RUN npm install -g typescript vsce
 
 WORKDIR /workspace

build/all.bash

@@ -51,7 +51,7 @@ run_test() {
   npm run lint
 
   echo "**** Run settings generator ****"
-  go run tools/generate.go -w=false
+  go run tools/generate.go -w=false -gopls=true
 
   echo "**** Check if vsce works ****"
   vsce package
@@ -115,7 +115,7 @@ install_dependencies() {
 	GO111MODULE=on go get github.com/sqs/goreturns
 	GO111MODULE=on go get github.com/uudashr/gopkgs/v2/cmd/gopkgs
 	GO111MODULE=on go get github.com/zmb3/gogetdoc
-	GO111MODULE=on go get golang.org/x/lint/golint
+	GO111MODULE=on go get honnef.co/go/tools/...
 	GO111MODULE=on go get golang.org/x/tools/cmd/gorename
 	GO111MODULE=on go get github.com/go-delve/delve/cmd/dlv@master
 }

docs/settings.md

@@ -235,7 +235,7 @@ Flags to pass to format tool (e.g. ["-s"]). Not applicable when using the langua
 Not applicable when using the language server. Choosing 'goimports', 'goreturns', or 'gofumports' will add missing imports and remove unused imports.<br/>
 Allowed Options: `gofmt`, `goimports`, `goreturns`, `goformat`, `gofumpt`, `gofumports`
 
-Default: `"goreturns"`
+Default: `"goimports"`
 ### `go.generateTestsFlags`
 
 Additional command line flags to pass to `gotests` for generating tests.
@@ -312,9 +312,9 @@ Default: `"package"`
 ### `go.lintTool`
 
 Specifies Lint tool name.<br/>
-Allowed Options: `golint`, `golangci-lint`, `revive`, `staticcheck`
+Allowed Options: `staticcheck`, `golint`, `golangci-lint`, `revive`
 
-Default: `"golint"`
+Default: `"staticcheck"`
 ### `go.liveErrors`
 
 Use gotype on the file currently being edited and report any semantic or syntactic errors found after configured delay. Not applicable when using the language server.
@@ -581,13 +581,13 @@ Example Usage:
 
 | Properties | Description |
 | --- | --- |
-| `gc_details` | gc_details controls calculation of gc annotations. <br/> <br/> Default: `false` |
-| `generate` | generate runs `go generate` for a given directory. <br/> <br/> Default: `true` |
-| `regenerate_cgo` | regenerate_cgo regenerates cgo definitions. <br/> <br/> Default: `true` |
-| `test` | test runs `go test` for a specific test function. <br/> <br/> Default: `false` |
-| `tidy` | tidy runs `go mod tidy` for a module. <br/> <br/> Default: `true` |
-| `upgrade_dependency` | upgrade_dependency upgrades a dependency. <br/> <br/> Default: `true` |
-| `vendor` | vendor runs `go mod vendor` for a module. <br/> <br/> Default: `true` |
+| `gc_details` | Toggle the calculation of gc annotations. <br/> Default: `false` |
+| `generate` | Runs `go generate` for a given directory. <br/> Default: `true` |
+| `regenerate_cgo` | Regenerates cgo definitions. <br/> Default: `true` |
+| `test` | Runs `go test` for a specific set of test or benchmark functions. <br/> Default: `false` |
+| `tidy` | Runs `go mod tidy` for a module. <br/> Default: `true` |
+| `upgrade_dependency` | Upgrades a dependency in the go.mod file for a module. <br/> Default: `true` |
+| `vendor` | Runs `go mod vendor` for a module. <br/> Default: `true` |
 ### `ui.completion.completionBudget`
 
 (For Debugging) completionBudget is the soft latency goal for completion requests. Most

docs/tools.md

@@ -60,13 +60,14 @@ This tool provides support for the [`Go: Generate Interface Stubs`](features.md#
 
 This tool provides support for the [`Go: Generate Unit Tests`](features.md#generate-unit-tests) set of commands.
 
-### [`golint`]
+### [`staticcheck`]
 
-This is the default lint tool. Other lint tools can be used by configuring the [`"go.lintTool"`](settings.md#go.lintTool) setting. Other options include:
+This is the default lint tool. See the [full list of checks](https://staticcheck.io/docs/checks) that `staticcheck` provides. Other lint tools can be used by configuring the [`"go.lintTool"`](settings.md#go.lintTool) setting.
+Other options include:
 
-  * [`staticcheck`]: This tool provides a great deal of useful checks that are not provided by [`golint`]. See the full list at [staticcheck.io/docs/checks](https://staticcheck.io/docs/checks). It is also officially supported by the [Go team at Google](https://staticcheck.io/sponsors).
-  * [`golangci-lint`]: This tool combines a number of existing lint tools, including [staticcheck](#staticcheck), into one interface.
+  * [`golangci-lint`]: This meta-linter combines a number of existing lint tools, including [staticcheck](#staticcheck), into one interface.
   * [`revive`]: This tool is an enhancement on top of [`golint`], and it provides additional checks.
+  * [`golint`]: This used to be the default linter used by this extension before it was officially deprecated.
 
 You can use the [`"go.lintFlags"`](settings.md#go.lintFlags) setting to further configure your linter of choice. Most linters can be configured via special configuration files, but you may still need to pass these command-line flags. The configuration documentation for each supported linter is listed here:
 
@@ -115,11 +116,11 @@ It can also be used to provide the [go to definition](features.md#go-to-definiti
 
 * [`gogetdoc`], [`godef`], [`godoc`]: these are documentation tools used for the [go to definition](features.md#go-to-definition), [signature help](features.md#signature-help), and [quick info on hover](features.md#quick-info-on-hover) in the legacy mode. [`guru`](#guru) can also be used, but only for the [go to definition](features.md#go-to-definition) behavior. Configure this via the [`"go.docsTool"`](settings.md#go.docsTool) setting.
 
-* [`goreturns`], [`gofmt`], [`goimports`]: Formatting tools are used by the [formatting and import organization](features.md#format-and-organize-imports) features. [`goreturns`] is used by default in the legacy mode. It formats the file according to the industry standard [`gofmt`] style, organizes imports, and fills in default return values for functions. Other tools can be used for formatting instead; this can be configured with the [`"go.go.formatTool"`](settings.md#formatTool) setting. Note that [`goreturns`] does not have support for Go modules.
+* [`goimports`], [`gofmt`]: Formatting tools are used by the [formatting and import organization](features.md#format-and-organize-imports) features. [`goreturns`] is used by default in the legacy mode. It formats the file according to the industry standard [`gofmt`] style, organizes imports, and fills in default return values for functions. Other tools can be used for formatting instead; this can be configured with the [`"go.go.formatTool"`](settings.md#formatTool) setting.
 
-  * [`goimports`], which applies the default `gofmt` style and organizes imports, but without the behavior of filling in default return values
   * [`gofmt`] only formats the file, without import organization or filling in return values
   * [`goformat`] is a configurable version of [`gofmt`]
+  * [`goreturns`] fills in default return values for functions, in addition to applying `goimports`-style formatting. This tool does not have support for Go modules.
 
 * Diagnostics tools: By default, [`gotype-live`], [`go vet`], and [`golint`] are used to provide [build](features.md#build-errors), [vet](features.md#vet-errors), and [lint](features.md#lint-errors) errors. [`gotype-live`] provides build errors as you type, while `go build` can be used to show build errors only on save. [`gotype-live`] does not work with modules.
 

go.mod

@@ -0,0 +1,3 @@
+module github.com/golang/vscode-go
+
+go 1.16