Skip to content

Commit 38e85e5

Browse files
committed
[dev.go2go] all: change name and don't suggest recompiling Go tools
Change the name of the extension to make it more distinctive. Also, don't offer to recompile Go tools. Change-Id: Ic5874f88b0c43d69cf4bdd467793512f3e274359 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/238318 Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
1 parent 641094c commit 38e85e5

File tree

3 files changed

+13
-11
lines changed

3 files changed

+13
-11
lines changed

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
{
2-
"name": "go-nightly",
3-
"displayName": "Go Nightly",
2+
"name": "go2go",
3+
"displayName": "Go (go2go)",
44
"version": "0.0.0",
55
"publisher": "golang",
6-
"description": "Rich Go language support for Visual Studio Code (Nightly)",
6+
"description": "Rich Go language support for Visual Studio Code",
77
"author": {
88
"name": "Go Team at Google"
99
},

src/goMain.ts

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -79,16 +79,18 @@ export function activate(ctx: vscode.ExtensionContext): void {
7979
const prevGoroot = toolsGoInfo[toolsGopath].goroot;
8080
const currentGoroot: string = process.env['GOROOT'] && process.env['GOROOT'].toLowerCase();
8181
if (prevGoroot && prevGoroot.toLowerCase() !== currentGoroot) {
82-
vscode.window
83-
.showInformationMessage(
82+
// Don't suggest recompiling tools for the go2go version.
83+
if (false) {
84+
vscode.window.showInformationMessage(
8485
`Your current goroot (${currentGoroot}) is different than before (${prevGoroot}), a few Go tools may need recompiling`,
8586
updateToolsCmdText
8687
)
87-
.then((selected) => {
88-
if (selected === updateToolsCmdText) {
89-
installAllTools(true);
90-
}
91-
});
88+
.then((selected) => {
89+
if (selected === updateToolsCmdText) {
90+
installAllTools(true);
91+
}
92+
});
93+
}
9294
} else {
9395
const currentVersion = await getGoVersion();
9496
if (currentVersion) {

src/telemetry.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@
55

66
// TODO(hyangah): move this somewhere else (where easily modifiable during release process)
77

8-
export const extensionId: string = 'golang.go-nightly';
8+
export const extensionId: string = 'golang.go2go';

0 commit comments

Comments
 (0)